Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 19753 - tidy diffutils ebuild
Summary: tidy diffutils ebuild
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Core system (show other bugs)
Hardware: All Linux
: High trivial
Assignee: Mr. Bones. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-04-22 02:44 UTC by Mr. Bones. (RETIRED)
Modified: 2003-04-24 01:44 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---

Attachments
tidy diffutils ebuild (diffutils.patch,2.14 KB, patch)
2003-04-22 02:46 UTC, Mr. Bones. (RETIRED) 		Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mr. Bones. (RETIRED) gentoo-dev 2003-04-22 02:44:47 UTC 
diffutils ebuild could use sed -i instead of cp/sed.

I'll attach a patch.

Reproducible: Always
Steps to Reproduce:
1. cat /usr/portage/*/diffutils/*ebuild

Actual Results:  
see some cp/sed

Expected Results:  
sed -i
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2003-04-22 02:46:40 UTC 
Created attachment 10982 [details, diff]
tidy diffutils ebuild

This patch:

Adds >=sed-4.0.5 to DEPEND
Adds unique error messages to all die() functions
Does some mild formatting and white space cleanup
Comment 2 Mr. Bones. (RETIRED) gentoo-dev 2003-04-24 01:44:44 UTC 
It seems pretty tidy now.