Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 197433 - Please add app-office/openoffice-bin-2.3.1 to the tree
Summary: Please add app-office/openoffice-bin-2.3.1 to the tree
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo non-Linux Team
URL:
Whiteboard:
Keywords:
Depends on: 202804
Blocks:
  Show dependency tree
 
Reported: 2007-10-29 16:45 UTC by Jeremy Olexa (darkside) (RETIRED)
Modified: 2008-05-14 13:58 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patch to modify app-office/openoffice-bin-2.3.1.ebuild (oo-bin-ebuild.patch,2.82 KB, patch)
2007-12-19 18:57 UTC, Jeremy Olexa (darkside) (RETIRED)
Details | Diff
patch needed to modify files in ${T} (openoffice-bin-2.3.1-prefix.patch,1.00 KB, patch)
2007-12-19 18:58 UTC, Jeremy Olexa (darkside) (RETIRED)
Details | Diff
cleaner patch, same content (openoffice-bin-2.3.1-prefix.patch,610 bytes, patch)
2008-01-09 17:26 UTC, Jeremy Olexa (darkside) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2007-10-29 16:45:13 UTC
I sucessfully emerged oo-bin on x86 linux hardware. I needed to add eselect-oodict to my overlay as well. Ran eapify on both ebuilds and grabbed the patches in the x86 tree. I had to modifiy the patches to get everything to work, extremely trivial modifications listed below. Compiles AND runs fine. trivial to add to the tree. EXCEPT: I removed glibc as a dep of the ebuild, because we can assume the host system has it on x86 or amd64 (linux)...I think.


% cat app-office/openoffice-bin/files/50-openoffice-bin 
SEARCH_DIRS_MASK="$EPREFIX/usr/lib/openoffice $EPREFIX/usr/lib32/openoffice"

% cat app-office/openoffice-bin/files/wrapper.in 
#!/bin/sh
export OOO_EXTRA_ARG=''
unset PYTHONPATH
$EPREFIX/usr/LIBDIR/openoffice/program/soffice  "$@"

(Only thing added to these two file is the 3 instances of $EPREFIX.)
Comment 1 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2007-11-05 16:04:16 UTC
This is the version that I used:
app-office/openoffice-bin-2.3.0
Comment 2 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2007-11-05 16:50:39 UTC
Oh, possible snag and not so trivial.

"For this reason, keep in mind that changes to those files get lost upon the next run of eupdate. Since this is done almost daily, the modifications disappear soon enough. Only files with a CVS $ Header: (such as ebuilds) can be changed in such a way that the modifications are not lost."

So..how do you handle the updates needed to the files in */files? Create a patch that modifies them?
Comment 3 Fabian Groffen gentoo-dev 2007-11-28 19:00:02 UTC
We need a patch here that patches the config file using @GENTOO_PORTAGE_EPREFIX@, to be applied somewhere in ${T} or ${S}.  Then run eprefixify on the patched file in the build's src_unpack.  Don't forget to use the patched file, and not the one from ${FILESDIR}.
Comment 4 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2007-12-19 18:47:24 UTC
Pulled eselect-oodict into a new bug. I will post my patch for this bug soon.
Comment 5 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2007-12-19 18:57:13 UTC
Created attachment 138899 [details, diff]
patch to modify app-office/openoffice-bin-2.3.1.ebuild

To make the openoffice ebuild work with prefix:
1) apply this patch to the ORIGINAL ebuild to modify the ebuild
2) put my ${P}-prefix.patch file in ${FILESDIR}

(This patch includes the changes made by eapify, so you don't need to run that first.)
Comment 6 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2007-12-19 18:58:07 UTC
Created attachment 138901 [details, diff]
patch needed to modify files in ${T}
Comment 7 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-01-09 17:26:05 UTC
Created attachment 140560 [details, diff]
cleaner patch, same content
Comment 8 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-05-13 22:25:29 UTC
openoffice-bin-2.4.0 added to tree. Removed glibc as a dep. Added prefix patch to FILESDIR. works ;-)

Committed revision 21974.

Comment 9 Fabian Groffen gentoo-dev 2008-05-14 08:07:47 UTC
did you remove the dep on glibc or did you make it conditional depending on !prefix? ( glibc )  ?
Comment 10 Jeremy Olexa (darkside) (RETIRED) archtester gentoo-dev Security 2008-05-14 13:58:09 UTC
(In reply to comment #9)
> did you remove the dep on glibc or did you make it conditional depending on
> !prefix? ( glibc )  ?

I removed it. I didn't even think about doing !prefix. But, that makes sense based on the goal that we want all ebuilds to be able to be merged someday, I'll change it.