Using emacs-cvs-22.1.50_p20070829-r1 and elscreen-1.4.5-r1 I've found some problems. Trying to use "calculator" I get the following message: split-window-vertically: Window height 2 too small (after splitting) Also, opening a latex file using auctex and then running M-x ispell the same message is shown. Using elscreen-toggle-display-tab to disable the tab fixes the problem. Any ideas where to look for? Reproducible: Always Steps to Reproduce: 1.Open emacs with elscreen loaded 2.run M-x calculator 3. Actual Results: Error message: Window height 2 too small (after splitting) Expected Results: See calclulator buffer Portage 2.1.3.9 (default-linux/amd64/2006.1, gcc-4.1.2, glibc-2.6.1-r0, 2.6.22-g entoo-r8 x86_64) ================================================================= System uname: 2.6.22-gentoo-r8 x86_64 AMD Athlon(tm) 64 Processor 3500+ Timestamp of tree: Tue, 23 Oct 2007 18:00:01 +0000 app-shells/bash: 3.2_p17 dev-lang/python: 2.4.4-r5 dev-python/pycrypto: 2.0.1-r6 sys-apps/baselayout: 1.12.9-r2 sys-apps/sandbox: 1.2.17 sys-devel/autoconf: 2.13, 2.61-r1 sys-devel/automake: 1.4_p6, 1.5, 1.6.3, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10 sys-devel/binutils: 2.18-r1 sys-devel/gcc-config: 1.3.16 sys-devel/libtool: 1.5.24 virtual/os-headers: 2.6.22-r2 ACCEPT_KEYWORDS="amd64" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=k8 -msse3 -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/X11/xkb" CONFIG_PROTECT_MASK="/etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/revdep-reb uild /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d" CXXFLAGS="-march=k8 -msse3 -O2 -pipe" DISTDIR="/usr/portage/distfiles" FEATURES="ccache distlocks metadata-transfer parallel-fetch sandbox sfperms stri ct unmerge-orphans userfetch" GENTOO_MIRRORS="http://gentoo.osuosl.org/ ftp://distro.ibiblio.org/pub/linux/dis tributions/gentoo/ http://distro.ibiblio.org/pub/linux/distributions/gentoo/ htt p://distfiles.gentoo.org " LINGUAS="en es" MAKEOPTS="-j2" PKGDIR="/usr/portage/packages" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/di stfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*" PORTAGE_TMPDIR="/var/tmp" PORTDIR="/usr/portage" PORTDIR_OVERLAY="/usr/portage/local/layman/seemant /usr/portage/local/layman/ema cs /usr/portage/local/layman/sajinet /usr/local/portage" SYNC="rsync://rsync.gentoo.org/gentoo-portage" USE="X alsa amd64 bitmap-fonts bzip2 cli cracklib crypt dbus doc dri emacs fontc onfig gdbm gif gnutls gpm gtk gtk2 iconv imlib isdnlog jpeg midi mp3 mudflap ncu rses nls nptl nptlonly nvidia opengl openmp pam pcre perl png ppds pppd python r eadline reflection sdl session spell spl sqlite ssl svg tcpd truetype-fonts type 1-fonts unicode xorg xv zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt 87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x 0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PL UGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 i oplug ladspa lfloat linear meter mulaw multi null plug rate route share shm soft vol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse" KERNEL="linux" LCD_DEVICES="ba yrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en es" USERLAND="GNU" VIDEO_CARDS="nvidia" Unset: CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTA GE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Please try a real CVS build, in your case emacs-cvs-22.1.50-r1 and try again. The pXXX is just a snapshot before the merging of multi-tty branch into the trunk. We keep this as reference.
(In reply to comment #1) > Please try a real CVS build, in your case emacs-cvs-22.1.50-r1 and try again. This also happens with 22.1.50-r1 and 23.0.50 (i.e. Emacs 22 base branch and Emacs trunk). However, 22.1-r1 doesn't show the problem. Evaluating the following expression: (let ((window-min-height 2)) (split-window nil 2)) normally succeeds, but after elscreen is loaded, it will display the error message.
Created attachment 134298 [details, diff] emacs-cvs-window-size-reverse.patch It's this change in the Emacs 22 base branch: 2007-08-06 Martin Rudalics <rudalics@gmx.at> * window.c (window_min_size_2): New function. (window_min_size_1, size_window, Fdisplay_buffer) (Fsplit_window, adjust_window_trailing_edge): Use it to avoid windows without mode- or header-lines when window-min-height is too small. (size_window): Reset nodelete_p after testing it, following an earlier note by Kim F. Storm. (display_buffer): Do not set split_height_threshold to twice the value of window_min_height to avoid changing the value of a customizable variable. Rather explicitly check whether the height of the window that shall be splitted is at least as large as split_height_threshold. (Fwindow_full_width_p): New defun. (syms_of_window): Defsubr it. * window.h: Add EXFUN for Fwindow_full_width_p. Attached patch for emacs-cvs-22.1.50-r1 (which is just reverting the above) should fix it.
So, should we blame Emacs or ElScreen? Not sure about this, but my feeling it that changes to the Emacs 22 base branch should not break backwards compatibility in a way as we see it here. Could you please report the issue upstream to Emacs maintainers, maybe with a CC to ElScreen upstream (naoto@morishima.net)?
(In reply to comment #4) > So, should we blame Emacs or ElScreen? Not sure about this, but my feeling it > that changes to the Emacs 22 base branch should not break backwards > compatibility in a way as we see it here. > > Could you please report the issue upstream to Emacs maintainers, maybe with a > CC to ElScreen upstream (naoto@morishima.net)? > Fixed upstream. Thanks a lot
Thank you for reporting the issue. (In reply to comment #1) > The pXXX is just a snapshot before the merging of multi-tty branch into > the trunk. We keep this as reference. I have package.masked _p20070829 now (as it always should have been).
