Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 196624 - >=media-libs/libmad-0.15.1b-r2 doesn't respect CFLAGS
Summary: >=media-libs/libmad-0.15.1b-r2 doesn't respect CFLAGS
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-21 15:49 UTC by Brian Kroth
Modified: 2008-01-29 14:46 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
A patch to the stable ebuild to disable simultaneous builds. (libmad-0.15.1b-r2.ebuild.patch,423 bytes, patch)
2007-10-25 17:16 UTC, Brian Kroth
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Kroth 2007-10-21 15:49:15 UTC
Moved from https://bugs.gentoo.org/show_bug.cgi?id=163113

I have a complaint/suggestion about this CFLAGS tweaking that I'm wondering
about.  Let me know if this was the wrong place to bring this up.

I have a server running as a build host for i686 workstations.  The server's
processor specs are much better than some of the workstations.  It's a
Core2/Xeon with SSE3 and others.  Some of the workstations are Athlon XPs,
which only support SSE.

Since when it was built it detected some more advanced instructions, it gave me
"Illegal Instruction" complaints when run with audacious on the Athlons which
didn't have it.  GDB pointed back to libmad, and indeed, if I compile libmad
locally it seems to work fine, but if I had more than a handful of these it
would really be a pain, and it makes me wonder what else does that that I
haven't found yet.  Mplayer has the cpudetection flag which is handy for this
type of scenario.

Can we just make the use of the more advanced cpu features USE flag dependent
instead of build machine dependent?  It seems like that's what the sse, mmx,
sse2, 3dnow, etc. flags were for in the first place.  That way the user can
still define the greatest common denominator.

I will see if I can submit an ebuild patch shortly.
Comment 1 Brian Kroth 2007-10-25 17:16:05 UTC
Created attachment 134352 [details, diff]
A patch to the stable ebuild to disable simultaneous builds.
Comment 2 Brian Kroth 2007-10-25 17:16:49 UTC
I did some more testing on this and couldn't see anything obviously wrong in the configure scripts so I tried to do a diff on the output of the compiles on the build server vs. a local host.  Some lines weren't lining up in the same places so I thought I'd make my job easier by setting MAKEOPTS="-j1".  No difference in the output, so I decided to try running that build on the local machine.  Voila!  So, here's my patch to disable simultaneous builds.
Comment 3 Alexis Ballier gentoo-dev 2008-01-28 21:57:19 UTC
Hu ? I dont understand anything there: does your build log mentions some extra cpu flags used at compile time that would not work on your old box ? Have you been able to check if this is libmad asm being run where it should not ? (like with gdb you can track where the SIGILL comes from)

And more importantly, how does building with -j1 relates to a illegal instruction at runtime ???
Comment 4 Brian Kroth 2008-01-29 14:41:58 UTC
(In reply to comment #3)
> Hu ? I dont understand anything there: does your build log mentions some extra
> cpu flags used at compile time that would not work on your old box ? Have you
> been able to check if this is libmad asm being run where it should not ? (like
> with gdb you can track where the SIGILL comes from)
> 
> And more importantly, how does building with -j1 relates to a illegal
> instruction at runtime ???

I don't know, but at the time it appeared to fix the problem.  

In any case, I can't reproduce it now, so I think this can be closed.  Thanks.
Comment 5 Alexis Ballier gentoo-dev 2008-01-29 14:46:13 UTC
(In reply to comment #4)

> I don't know, but at the time it appeared to fix the problem.  
> 
> In any case, I can't reproduce it now, so I think this can be closed.  Thanks.

good ;)