Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 196486 - dev-util/bzr doesn't require {c,}elementtree with python 2.5
Summary: dev-util/bzr doesn't require {c,}elementtree with python 2.5
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 199112
  Show dependency tree
 
Reported: 2007-10-20 05:41 UTC by James Rowe
Modified: 2007-11-15 19:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
bzr-etree_depend.patch (bzr-etree_depend.patch,903 bytes, patch)
2007-10-20 05:41 UTC, James Rowe
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description James Rowe 2007-10-20 05:41:10 UTC
If you use python 2.5, then the celementtree dependency is unneeded.
As far back as 0.15, and maybe much further, the conditional imports
have been in the source.

  The attached patch makes the dependency conditional depending on the
python version, and while it is only for 0.91-r1 the patch applies
correctly with a smidgen of fuzz to all the other ebuilds.

Thanks,

James
Comment 1 James Rowe 2007-10-20 05:41:49 UTC
Created attachment 133928 [details, diff]
bzr-etree_depend.patch
Comment 2 James Rowe 2007-10-20 05:42:20 UTC
  Just out of curiosity, and while I have your attention is there any
reason the paramiko dep can't be conditional on USE=sftp?  bzr handles
the situation gracefully, and it is only required for SFTP support.

  I'm maybe missing some good reason though, as I only use bzr to dump
the history of a project that uses it in to another SCM.
Comment 3 Lukasz Strzygowski (RETIRED) gentoo-dev 2007-11-14 10:38:05 UTC
Fixed celementtree dep and added sftp USE-flag. Thanks for contribution.
Comment 4 Andrew Cowie 2007-11-14 11:32:37 UTC
Um, maybe USE=curl and USE=sftp should be enabled by default.

AfC
Sydney
Comment 5 Mark Lee 2007-11-15 19:08:07 UTC
(In reply to comment #4)
> Um, maybe USE=curl and USE=sftp should be enabled by default.
> 
...is that even possible with current portage?

FWIW, I agree.