Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 195926 - net-analyzer/pinger-0.32 ebuild improvement request: adding conditional GTK support + works on AMD64
Summary: net-analyzer/pinger-0.32 ebuild improvement request: adding conditional GTK s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: Lowest enhancement (vote)
Assignee: Gentoo Netmon project
URL: http://aa.vslib.cz/silk/projekty/ping...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-15 09:16 UTC by Davide Cendron (RETIRED)
Modified: 2008-02-25 18:59 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pinger-0.32.ebuild (pinger-0.32.ebuild,859 bytes, text/plain)
2007-10-15 09:17 UTC, Davide Cendron (RETIRED)
Details
autoconf-13029.out (autoconf-13029.out,202 bytes, text/plain)
2008-02-22 08:38 UTC, Davide Cendron (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Cendron (RETIRED) gentoo-dev 2007-10-15 09:16:32 UTC
Hi, i've seen that net-analyzer/pinger has a fixed dependency to GTK libs, but the build system of this package permits to compile it without this support, if needed (in server environments withouth X installation, for example 8) )

I've changed accordingly the ebuild, adding the "gtk" USE flag, and changing the src_{compile,install} functions.

So here's an improved ebuild ;)
Comment 1 Davide Cendron (RETIRED) gentoo-dev 2007-10-15 09:17:01 UTC
Created attachment 133524 [details]
pinger-0.32.ebuild
Comment 2 Davide Cendron (RETIRED) gentoo-dev 2007-10-15 23:02:03 UTC
Uhm... changing the behaviout of src_install weren't a good idea. With my submitted ebuild, the pinger executable hasn't the "suid" bit set.

So, please, hack the ebuild or the sources in a better way. Regarding the GTK support, i've seen that even if i force --disable-gtk, configure script always enable GTK support if detect a valid GTK installation.

Finally, please add ~amd64 keyword, as it works on this architecture (tested some minute ago) without problems.
Comment 3 Daniel Gryniewicz (RETIRED) gentoo-dev 2007-10-29 17:56:27 UTC
keyworded ~amd64
Comment 4 Raúl Porcel (RETIRED) gentoo-dev 2008-01-21 13:46:09 UTC
Fixed in .32c, let me know if you like it :)
Comment 5 Davide Cendron (RETIRED) gentoo-dev 2008-02-22 08:38:05 UTC
Unfortunately net-analyzer/pinger-0.32c still doesn't emerge correctly:

1 - (trivial issue): conditional dependency against GTK is missing, it would be

gtk? ( >=x11-libs/gtk+-2.4.0 ) 

2 - unpack process fails with the following error:

>>> Unpacking pinger-0.32c.tar.gz to /var/tmp/portage/net-analyzer/pinger-0.32c/work
 * Applying disable_gtk.patch ...                                                                                                                       [ ok ]
 * Running eautoreconf in '/var/tmp/portage/net-analyzer/pinger-0.32c/work/pinger-0.32c' ...
 * Running aclocal -I m4 ...                                                                                                                            [ ok ]
 * Running autoconf ...                                                                                                                                 [ !! ]

 * Failed Running autoconf !
 *
 * Include in your bugreport the contents of:
 *
 *   /var/tmp/portage/net-analyzer/pinger-0.32c/temp/autoconf-13029.out

 *
 * ERROR: net-analyzer/pinger-0.32c failed.
 * Call stack:
 *               ebuild.sh, line   49:  Called src_unpack
 *             environment, line 2492:  Called eautoreconf
 *             environment, line  822:  Called eautoconf
 *             environment, line  769:  Called autotools_run_tool 'src_unpack'
 *             environment, line  322:  Called die
 * The specific snippet of code:
 *           die "Failed Running $1 !";
 *  The die message:
 *   Failed Running autoconf !

I attach the output file as requested.

My emerge --info is:

Portage 2.1.4.4 (default-linux/x86/2007.0, gcc-4.1.2, glibc-2.6.1-r0, 2.6.23-gentoo-r3 i686)
=================================================================
System uname: 2.6.23-gentoo-r3 i686 Intel(R) Pentium(R) 4 CPU 3.00GHz
Timestamp of tree: Fri, 22 Feb 2008 07:30:02 +0000
distcc 2.18.3 i686-pc-linux-gnu (protocols 1 and 2) (default port 3632) [disabled]
app-shells/bash:     3.2_p17-r1
dev-lang/python:     2.4.4-r6
dev-python/pycrypto: 2.0.1-r6
sys-apps/baselayout: 1.12.11.1
sys-apps/sandbox:    1.2.18.1-r2
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.7.9-r1, 1.10
sys-devel/binutils:  2.18-r1
sys-devel/gcc-config: 1.4.0-r4
sys-devel/libtool:   1.5.26
virtual/os-headers:  2.6.23-r3
ACCEPT_KEYWORDS="x86"
CBUILD="i686-pc-linux-gnu"
CFLAGS="-O2 -march=i686 -pipe"
CHOST="i686-pc-linux-gnu"
CONFIG_PROTECT="/etc"
CONFIG_PROTECT_MASK="/etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/php/apache2-php5/ext-active/ /etc/php/cgi-php5/ext-active/ /etc/php/cli-php5/ext-active/ /etc/revdep-rebuild /etc/terminfo /etc/udev/rules.d"
CXXFLAGS="-O2 -march=i686 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks metadata-transfer sandbox sfperms strict unmerge-orphans userfetch"
GENTOO_MIRRORS="http://mirror.ing.unibo.it/gentoo/"
LANG="it_IT.UTF-8"
LC_ALL="it_IT.UTF-8"
LINGUAS="it"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_EXTRA_OPTS="--progress"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages"
PORTAGE_TMPDIR="/var/tmp"
PORTDIR="/usr/portage"
PORTDIR_OVERLAY="/usr/local/portage"
SYNC="rsync://172.16.61.65/gentoo-portage"
USE="acl apache2 berkdb bitmap-fonts cli cracklib crypt cups dri fortran gpm iconv isdnlog midi mudflap ncurses nls nptl nptlonly openmp pam pcre perl pppd python readline reflection session spl ssl tcpd threads truetype-fonts type1-fonts unicode x86 xorg zlib" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1 emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" APACHE2_MODULES="actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="it" USERLAND="GNU" VIDEO_CARDS="apm ark chips cirrus cyrix dummy fbdev glint i128 i740 i810 imstt mach64 mga neomagic nsc nv r128 radeon rendition s3 s3virge savage siliconmotion sis sisusb tdfx tga trident tseng v4l vesa vga via vmware voodoo"
Unset:  CPPFLAGS, CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS
Comment 6 Davide Cendron (RETIRED) gentoo-dev 2008-02-22 08:38:59 UTC
Created attachment 144298 [details]
autoconf-13029.out

Autoconf failure output
Comment 7 Peter Volkov (RETIRED) gentoo-dev 2008-02-25 18:59:18 UTC
Davide, well your compilation problem was because you did not have gtk+ installed. That is why gtk was enabled unconditionally... But well, now gtk+ is fully optional. Thank you for report. Fixed in CVS.