Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 195756 - libesmtp patch to make it work with prefixed portage
Summary: libesmtp patch to make it work with prefixed portage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: Prefix Support (show other bugs)
Hardware: All OS X
: High enhancement (vote)
Assignee: Gentoo non-Linux Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 195754
  Show dependency tree
 
Reported: 2007-10-13 20:35 UTC by Dirk Tilger
Modified: 2007-11-03 19:16 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to the libesmtp 1.0.4 ebuild to make it work with the prefixed portage (libesmtp-1.0.4.ebuild.patch,1.24 KB, patch)
2007-10-13 20:36 UTC, Dirk Tilger
Details | Diff
patch against eapify'ed ebuild (libesmtp.patch,830 bytes, patch)
2007-10-13 23:29 UTC, Elias Pipping (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Tilger 2007-10-13 20:35:21 UTC
The attached patch is to make libesmtp work with prefixed portage. This patch is required by bug 195754.

USE flags for testing: ssl -debug

objective: `emerge esmtp`

test system: x86-macos
Comment 1 Dirk Tilger 2007-10-13 20:36:13 UTC
Created attachment 133366 [details, diff]
Patch to the libesmtp 1.0.4 ebuild to make it work with the prefixed portage
Comment 2 Elias Pipping (RETIRED) gentoo-dev 2007-10-13 23:29:32 UTC
Created attachment 133389 [details, diff]
patch against eapify'ed ebuild

please diff against eapify'ed ebuilds (/usr/portage/scripts/eapify).
please quote EPREFIX and use braces: $EPREFIX -> "${EPREFIX}" (that doesn't apply to this diff because EPREFIX is never used, but it applies to e.g. bug #195750 and i thought i might as well put that here)

i've completely removed the libtool hack from the ebuild and it works for me. although i haven't investigated this, it's probably because gnu libtool was used when those lines were hacked in (no?) and it no longer is (we use the odcctools' libtool now). hence we wouldn't need to depend on libtool but the odcctools (which is obsolete because they're in 'system').

the libtool hack should be removed from the ebuild - not only in prefix but everywhere. I've gone ahead and removed it from the prefixified ebuild. (attaching a diff against the eupdated ebuild). not committing this for now because i'd like to hear grobian's opinion on this. a.) the hack doesn't do anything because no files are found - means we don't *have* to remove it - should we leave it in, keeping the diff down, and wait for semi-upstream to remove it? (i'd file a bug for that then), b.) what about the libtool dependency?

ps: the way that hack was done is awful too. one should use `mv ${foo} ${foo%.so}.dylib` if necessary.
Comment 3 Fabian Groffen gentoo-dev 2007-10-14 09:06:04 UTC
-	if use ppc-macos;
+	if use ppc-macos || use x86-macos;

Yeah... you're just dealing with one of my ultra dirty hacks of my ultra early days.  pipping's patch looks much nicer, because that hack is unaccepptable any mroe.  I'll remove it from the main tree.
Comment 4 Elias Pipping (RETIRED) gentoo-dev 2007-11-03 19:16:37 UTC
in prefix[1].


[1] http://overlays.gentoo.org/proj/alt/changeset/11880