Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 195218 - Please stabilize =sys-apps/lcdtest-1.08
Summary: Please stabilize =sys-apps/lcdtest-1.08
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Tony Vroon (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2007-10-09 11:52 UTC by Raúl Porcel (RETIRED)
Modified: 2007-10-28 13:55 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Add -h support to lcdtest.c (patch,360 bytes, patch)
2007-10-22 17:04 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff
Ebuild to apply diff (lcdtest-1.08-r1.ebuild,1.06 KB, text/plain)
2007-10-23 10:49 UTC, Thomas Anderson (tanderson) (RETIRED)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Raúl Porcel (RETIRED) gentoo-dev 2007-10-09 11:52:26 UTC
+30 days in the tree, no bugs, please do
Comment 1 Tony Vroon (RETIRED) gentoo-dev 2007-10-22 15:18:36 UTC
Alright arch teams, let's go for it. Added X86 keyword myself, will look at PPC tonight.
Comment 2 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-10-22 17:03:01 UTC
Well, on amd64, everything builds and runs fine, but there is a small problem. lcdtest lists -h in the man page but doesn't accept it in the program. It does, however, accept -?.Therefore I made up a quick patch to fix the issue. Attaching shortly.
Comment 3 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-10-22 17:04:52 UTC
Created attachment 134120 [details, diff]
Add -h support to lcdtest.c
Comment 4 Tony Vroon (RETIRED) gentoo-dev 2007-10-22 21:46:32 UTC
Build system had a cow about this patch somehow. However, I rewrote the build system in an ebuild as I detest scons anyway. Thanks Thomas, would you mind testing this on AMD64 again? PPC is done now, readding X86 keyword as I won't see an X86 machine until I get back to work tomorrow morning.
Comment 5 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-10-23 10:49:50 UTC
Created attachment 134166 [details]
Ebuild to apply diff

Hi, it really isn't necessary to redo the buildsystem(although I hate scons too and would like to see it get taken out back and shot). I have this ebuild which will apply the patch(it works on amd64 at least). I may or may not get to testing the new ebuild today. 

Also, are we supposed to be marking -r1 stable now?
Comment 6 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-10-23 11:01:08 UTC
Apparently beandog stabilized this on amd64 already.

However, I should mention that the new ebuild works flawlessly here. The only complaint I really have is that you supress all the compilation lines(gcc output), which isn't very nice.
Comment 7 Tony Vroon (RETIRED) gentoo-dev 2007-10-23 13:07:45 UTC
(In reply to comment #6)
> However, I should mention that the new ebuild works flawlessly here. The only
> complaint I really have is that you supress all the compilation lines(gcc
> output), which isn't very nice.

Feel free to submit a patch that changes that. Note that starting to use scons again is unacceptable. 

Comment 8 Tony Vroon (RETIRED) gentoo-dev 2007-10-23 13:30:58 UTC
Marked stable on X86. Beandog added an AMD64 keyword already, dropping CC. That leaves just PPC64. I'll have a look tonight.
Comment 9 Markus Rothe (RETIRED) gentoo-dev 2007-10-28 13:54:24 UTC
ppc64 stable
Comment 10 Tony Vroon (RETIRED) gentoo-dev 2007-10-28 13:55:45 UTC
That's all folks!