194940 – [PATCH] add vim and perforce bits for dev-util/git

Bug 194940 - [PATCH] add vim and perforce bits for dev-util/git

Summary: [PATCH] add vim and perforce bits for dev-util/git

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All Linux

Importance:	High normal (vote)
Assignee:	Vim Maintainers

URL:
Whiteboard:
Keywords:

Duplicates (2):	182859 196428 (view as bug list)
Depends on:
Blocks:

Reported:	2007-10-06 22:32 UTC by Saleem Abdulrasool (RETIRED)
Modified:	2008-05-28 17:43 UTC (History)
CC List:	5 users (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
vim-plugin.eclass.diff (vim-plugin.eclass.diff,646 bytes, patch) 2007-10-20 09:10 UTC, Jakub Moc (RETIRED)	Details \| Diff
vim-plugin.eclass.2.diff (vim-plugin.eclass.2.diff,787 bytes, patch) 2007-11-04 17:12 UTC, Ali Polatel (RETIRED)	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Saleem Abdulrasool (RETIRED) gentoo-dev

2007-10-06 22:32:12 UTC

As per conversation on irc: http://compnerd.org/~compnerd/temp/git-1.5.3.3.patch

Comment 1 Fernando J. Pereda (RETIRED) gentoo-dev

2007-10-19 08:00:12 UTC

*** Bug 182859 has been marked as a duplicate of this bug. ***

Comment 2 Fernando J. Pereda (RETIRED) gentoo-dev

2007-10-19 09:33:54 UTC

Ok, I finally added something similar to that. Thanks.

- ferdy

Comment 3 Jakub Moc (RETIRED) gentoo-dev

2007-10-19 16:52:03 UTC

*** Bug 196428 has been marked as a duplicate of this bug. ***

Comment 4 Jakub Moc (RETIRED) gentoo-dev

2007-10-19 16:55:09 UTC

Except that vim-plugin eclass depends on (g)vim unconditionally, which is completely stupid for any usage in ebuilds. Why's no use flag there?

Comment 5 Fernando J. Pereda (RETIRED) gentoo-dev

2007-10-20 08:54:48 UTC

heh... don't ask me. I had already reverted that change...

- ferdy

Comment 6 Jakub Moc (RETIRED) gentoo-dev

2007-10-20 09:10:52 UTC

Created attachment 133936 [details, diff]
vim-plugin.eclass.diff

Trivial patch. Stick VIM_OPTIONAL="yes" before inherit for using this eclass outside of app-vim/*

This avoids injecting bogus vim use flag to app-vim/ ebuilds.

Comment 7 Fernando J. Pereda (RETIRED) gentoo-dev

2007-10-20 20:10:38 UTC

Checking CATEGORY looks like a better way to implement that logic

- ferdy

Comment 8 Saleem Abdulrasool (RETIRED) gentoo-dev

2007-10-30 06:25:19 UTC

For the perforce change, any chance you can actually install git-p4 into /usr/bin/ ?

Comment 9 Ali Polatel (RETIRED) gentoo-dev

2007-11-04 17:12:56 UTC

Created attachment 135169 [details, diff]
vim-plugin.eclass.2.diff

I think a simpler approach is removing the default for VIM_PLUGIN_VERSION, check if that's set in the ebuild and add DEPEND. Similar to NEED_PYTHON from python eclasses.

Comment 10 Robin Johnson archtester

2007-12-25 08:51:11 UTC

perforce bits added.
compnerd's original patch is missing here, please repost.

If the vim folk can resolve their optional issue, then assign it back to ferdy or myself to put the relevant stuff into git again.

Comment 11 Robin Johnson archtester

2008-05-28 17:43:56 UTC

Nobody responded to me here, so I'm just installing into vimfiles with doins and not using the eclass at all. In the tree as of 1.5.5.3.