Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 194883 - kde-base/kdenetwork: Kopete does not export custom emoticons
Summary: kde-base/kdenetwork: Kopete does not export custom emoticons
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] KDE (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo KDE team
URL: http://people.debian.org/~terpstra/me...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-10-06 06:39 UTC by Paúl Andrés Jiménez
Modified: 2007-10-20 23:34 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to fix the bug (kopete-3.5.7-msn-emoticon.patch,3.54 KB, patch)
2007-10-06 06:40 UTC, Paúl Andrés Jiménez
Details | Diff
Modified ebuild to include patch (kdenetwork-3.5.7-r1.ebuild,2.98 KB, text/plain)
2007-10-06 06:41 UTC, Paúl Andrés Jiménez
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Paúl Andrés Jiménez 2007-10-06 06:39:29 UTC
If you enable the option to export your custom MSN emoticons, your contacts using MSN Live won't receive them.
The problem has been solved in SVN already. The patch is also available. I modified kdenetwork-3.5.7-r1.ebuild to include the patch, then re-emerged kdenetwork. The patch was applied without problems, the package was compiled and installed. The newly compiled Kopete is now able to send custom emoticons (it was verified with two MSN Live users).

Reproducible: Always

Steps to Reproduce:
1. Enable "Export custom emoticons" for the MSN protocol.
2. Send a custom emoticon.

Actual Results:  
The contact reports an empty message.

Expected Results:  
The contact should see the custom emoticon.
Comment 1 Paúl Andrés Jiménez 2007-10-06 06:40:51 UTC
Created attachment 132707 [details, diff]
Patch to fix the bug
Comment 2 Paúl Andrés Jiménez 2007-10-06 06:41:36 UTC
Created attachment 132708 [details]
Modified ebuild to include patch
Comment 3 Tobias Heinlein (RETIRED) gentoo-dev 2007-10-06 11:58:35 UTC
Thanks for reporting.

However, I have some questions:
It seems your patch contains the changes applied in upstream's r704400 and r717106. What does the latter have to do with this issue?
If the former is supposed to fix the emoticons issue, why is the upstream bug (http://bugs.kde.org/show_bug.cgi?id=129929) still opened?
Comment 4 Wulf Krueger (RETIRED) gentoo-dev 2007-10-06 12:07:29 UTC
Tomorrow, KDE 3.5.8 will be tagged and released about a week later. If this is fixed in upstream's svn, it should be in it.

We'll keep this bug open for now to test with 3.5.8 but I don't see us fixing it in 3.5.7.
Comment 5 Paúl Andrés Jiménez 2007-10-06 19:20:21 UTC
> It seems your patch contains the changes applied in upstream's r704400 and
> r717106. What does the latter have to do with this issue?

Nothing, it seems. I just used the patch you can find in the URL link of this bug report, which solved this problem. I ignore why they mixed two, apparently, unrelated things in the same patch and reported that it fixed only one.

> If the former is supposed to fix the emoticons issue, why is the upstream bug
> (http://bugs.kde.org/show_bug.cgi?id=129929) still opened?
 
That's a very good question, and I completely ignore the answer. It should have been closed when they committed those changes. Perhaps the developer forgot to close it?

> Tomorrow, KDE 3.5.8 will be tagged and released about a week later. If this is
> fixed in upstream's svn, it should be in it.

I'm aware 3.5.8 is coming soon. Thing is that it's not a bug only present in 3.5.7, but it also exists in previous versions (the bug report in KDE shows that it was reported since 3.5.2).

I just checked the ebuilds and 3.5.5 is the latest stable version in portage, both 3.5.6 and 3.5.7 are marked ~ for all architectures. I don't feel like downgrading KDE just to test the patch in 3.5.5 and 3.5.6, but it should solve the problem there too. All I wanted to do was to share the patch. After all, adding a patch to any package in portage is quite easy.

> We'll keep this bug open for now to test with 3.5.8 but I don't see us fixing
> it in 3.5.7.

I will upgrade to 3.5.8 when it comes out, so I won't need the patch anymore, neither anyone upgrading to it. It's not a critical bug, so it's OK if you don't include it for previous versions of KDE.
Comment 6 Wulf Krueger (RETIRED) gentoo-dev 2007-10-06 21:34:49 UTC
(In reply to comment #5)
>> Tomorrow, KDE 3.5.8 will be tagged and released about a week later. 
>>If this is fixed in upstream's svn, it should be in it.
> I just checked the ebuilds and 3.5.5 is the latest stable version in portage,
> both 3.5.6 and 3.5.7 are marked ~ for all architectures. 

You should *really* sync. 3.5.7 has been marked stable for quite some time now. :-)

> All I wanted to do was to share the patch. After all,
> adding a patch to any package in portage is quite easy.

Yes, thanks, don't get me wrong: It's nice of you to share it. It's just that on the upstream bug people still complain that it doesn't work even with the patch included. I'm going to take a look at this once 3.5.8 is in Portage.
Comment 7 Wulf Krueger (RETIRED) gentoo-dev 2007-10-20 23:34:46 UTC
This is fixed in 3.5.8.