194855 – darcs.eclass - use rsync for copy rather than cp

Bug 194855 - darcs.eclass - use rsync for copy rather than cp

Summary: darcs.eclass - use rsync for copy rather than cp

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	Lowest enhancement (vote)
Assignee:	No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-10-05 21:25 UTC by Avuton Olrich
Modified:	2007-11-01 19:26 UTC (History)
CC List:	1 user (show)

See Also:
Package list:
Runtime testing required:	---

Attachments
darcs.patch (darcs.patch,492 bytes, patch) 2007-10-05 21:25 UTC, Avuton Olrich	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Avuton Olrich 2007-10-05 21:25:11 UTC

It would be nice to use rsync for copying rather than cp, like the subversion.eclass does, to prevent the darcs data directory from copying to ${S}.

Here's an inline patch, will attach also:

--- a/darcs.eclass
+++ b/darcs.eclass
@@ -142,7 +142,7 @@ darcs_src_unpack() {

        EDARCS_SHOPT=$(shopt -p dotglob)
        shopt -s dotglob        # get any dotfiles too.
-       cp -Rf "$EDARCS_TOP_DIR/$EDARCS_LOCALREPO"/* "${WORKDIR}/${P}"
+       rsync -rlpgo --exclude="_darcs/"  "$EDARCS_TOP_DIR/$EDARCS_LOCALREPO"/* "${WORKDIR}/${P}"
        eval ${EDARCS_SHOPT}    # reset shopt

        einfo "Darcs repository contents are now in ${WORKDIR}/${P}"

Comment 1 Avuton Olrich 2007-10-05 21:25:40 UTC

Created attachment 132684 [details, diff]
darcs.patch

Comment 2 Lennart Kolmodin (RETIRED) gentoo-dev

2007-10-07 12:29:56 UTC

Thank you,
your patch has been applied to the haskell overlay.

Comment 3 Lennart Kolmodin (RETIRED) gentoo-dev

2007-11-01 19:26:26 UTC

Committed to the tree.
Thanks Avuton!