Hi, unzip-5.52-r1 cannot handle filesizes >2gb, e.g. the 2.73gb rygel-dp-texturepack-ultra.pk3 from http://www.quakeone.com/forums/showthread.php?t=2778 Ubuntu's diff: http://archive.ubuntu.com/ubuntu/pool/main/u/unzip/unzip_5.52-10ubuntu1.diff.gz Includes the following line: +DEFINES = -DACORN_FTYPE_NFS -DWILD_STOP_AT_DIR -D_LARGEFILE64_SOURCE -D_FILE_OFFSET_BITS=64 And also contains: + * Added appropriate compiler flags for Large File Support (Closes: #192253). + This procedure is blessed by upstream in the FAQ, and as a result, + some .zip archives may now be uncompressed using Debian unzip. The bug mentioned is: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=192253 The FAQ is: http://www.info-zip.org/FAQ.html#limits Which specifies: -DLARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 "LARGEFILE" doesn't even exist in the source - all that is needed is: -D_FILE_OFFSET_BITS=64 Enclosed is a patch to add >2gb filesize support. Works with the above file on x86. Properly fixes #104315.
Created attachment 132228 [details, diff] unzip-5.52-r1.diff
Comment on attachment 132228 [details, diff] unzip-5.52-r1.diff umm, no ... if you read the ebuild, you'll see we already call append-lfs-flags the fix is to make sure env CPPFLAGS are respected
Created attachment 132437 [details, diff] unzip-5.52-r1.diff Simple addition of CPPFLAGS, to make append-lfs-flags effective.
looks good, added to the tree ... thanks
