Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 193260 - app-pda/jpilot-plucker - change in pilot-link API causes breakage
Summary: app-pda/jpilot-plucker - change in pilot-link API causes breakage
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo PDA project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-20 23:06 UTC by Mark Wagner
Modified: 2007-09-21 21:37 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
fix (patch.txt,442 bytes, patch)
2007-09-20 23:06 UTC, Mark Wagner
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wagner 2007-09-20 23:06:32 UTC
With pilot-link 0.12 (or 0.12.2?) there are some changes to its API. Any software that doesn't handle this will break.

For example, in app-pda/jpilot-plucker we have this call to a pilot-link function:

rval = pi_file_install (f, sd, 0);

for 0.12 onward that should be

rval = pi_file_install (f, sd, 0, NULL);

All apps that use pilot-link may be in for a world of hurt. For example jpilot doesn't compile anymore (but that's another bug).



Reproducible: Always

Steps to Reproduce:
1. emerge app-pda/jpilot-plucker
2. weep


Actual Results:  
plugin.c: In function 'sync_install':
plugin.c:271: error: too few arguments to function 'pi_file_install'
make[2]: *** [plugin.lo] Error 1


Expected Results:  
Shiny new jpilot-plucker.

Portage 2.1.3.9 (default-linux/amd64/2007.0/desktop, gcc-4.2.0, glibc-2.6.1-r0, 2.6.22-gentoo-r6 x86_64)
=================================================================
System uname: 2.6.22-gentoo-r6 x86_64 AMD Athlon(tm) 64 Processor 3000+
Timestamp of tree: Wed, 19 Sep 2007 20:20:01 +0000
app-shells/bash:     3.2_p17-r1
dev-java/java-config: 1.3.7, 2.0.33-r1
dev-lang/python:     2.5.1-r2
sys-apps/baselayout: 1.12.10-r4
sys-apps/sandbox:    1.2.18.1
sys-devel/autoconf:  2.13, 2.61-r1
sys-devel/automake:  1.4_p6, 1.5, 1.7.9-r1, 1.8.5-r3, 1.9.6-r2, 1.10
sys-devel/binutils:  2.18
sys-devel/gcc-config: 1.4.0-r2
sys-devel/libtool:   1.5.24
virtual/os-headers:  2.6.22-r2
ACCEPT_KEYWORDS="amd64 ~amd64"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=k8 -O2 -pipe"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/kde/3.5/env /usr/kde/3.5/share/config /usr/kde/3.5/shutdown /usr/share/X11/xkb /usr/share/config"
CONFIG_PROTECT_MASK="/etc/env.d /etc/env.d/java/ /etc/gconf /etc/revdep-rebuild /etc/splash /etc/terminfo /etc/texmf/web2c /etc/udev/rules.d"
CXXFLAGS="-march=k8 -O2 -pipe"
DISTDIR="/usr/portage/distfiles"
FEATURES="distlocks fixpackages metadata-transfer sandbox sfperms strict unmerge-orphans userfetch userpriv usersandbox"
GENTOO_MIRRORS="http://gentoo.osuosl.org/"
LINGUAS="en de"
MAKEOPTS="-j2"
PKGDIR="/usr/portage/packages"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --compress --force --whole-file --delete --delete-after --stats --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --filter=H_**/files/digest-*"
PORTAGE_TMPDIR="/m/tmp/freddy/var/tmp/portage"
PORTDIR="/usr/portage"
SYNC="rsync://www.lanfear.net/gentoo-portage"
USE="X Xaw3d a52 aac aalib acl acpi adns alsa amd64 audiofile avi bash-completion berkdb bitmap-fonts browserplugin bzip2 cairo cddb cdparanoia cdr cli cracklib crypt cups curl dbus dga divx4linux dpms dri dts dv dvb dvd dvdr dvdread dynagraph edl emacs emboss encode evo exif faac faad fame fb ffmpeg firefox flac fltk font-server fontconfig foomaticdb fpx freetype gd gdbm geoip gif gimpprint glibc-omitfp glut gmp gnutls gpgme gphoto2 graphviz gs gstreamer gtk gtk2 hal iconv idea imagemagick imap ipod isdnlog jack java javascript jbig jikes jpeg jpeg2k ladcca ladspa lash lcms libcaca libnotify libsamplerate live lm_sensors logitech-mouse logrotate lzo mad mailwrapper matroska mbox midi mikmod milter mjpeg mmap mmx mng modplug mozdevelop moznocompose moznoirc moznomail mozsvg mp3 mpeg mplayer mudflap musepack musicbrainz ncurses nethack network nls nptl nptlonly nsplugin nvidia offensive ofx ogg openal opengl openmp oss pam pam_chroot pam_console pam_timestamp pcre pdf pdflib perl perlsuid pic plotutils png portaudio ppds pppd python qt3 qt3support qt4 quicktime rar readline reflection rtc sdl sensord session sid silc slp smime smp sndfile snmp speex spell spl sqlite sse sse2 ssl subtitles svg tagwriting tcltk tcpd tga theora timidity truetype truetype-fonts type1-fonts unicode vcd visualization vorbis vorbis-psy wma wmf wxgtk1 x264 xanim xml xorg xprint xrandr xv xvid yv12 zlib" ALSA_CARDS="emu10k1" ALSA_PCM_PLUGINS="adpcm alaw asym copy dmix dshare dsnoop empty extplug file hooks iec958 ioplug ladspa lfloat linear meter mulaw multi null plug rate route share shm softvol" ELIBC="glibc" INPUT_DEVICES="keyboard mouse evdev" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LINGUAS="en de" USERLAND="GNU" VIDEO_CARDS="nvidia nv vesa fbdev"
Unset:  CTARGET, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LANG, LC_ALL, LDFLAGS, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, PORTDIR_OVERLAY
Comment 1 Mark Wagner 2007-09-20 23:06:56 UTC
Created attachment 131470 [details, diff]
fix
Comment 2 Mark Wagner 2007-09-20 23:14:32 UTC
Scratch that comment about jpilot. It still compiles ok.
Comment 3 Wulf Krueger (RETIRED) gentoo-dev 2007-09-21 21:37:15 UTC
Thanks, Mark! Fixed in CVS.