Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 19317 - eclipse SDK 2.1 source ebuild (update/bugfix)
Summary: eclipse SDK 2.1 source ebuild (update/bugfix)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Karl Trygve Kalleberg (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 18754
Blocks:
  Show dependency tree
 
Reported: 2003-04-14 15:10 UTC by Jesse
Modified: 2003-10-05 14:33 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Diff for eclipse-SDK-2.1.ebuild (To bring to -r1?) (eclipse-SDK-2.1.diff,9.06 KB, patch)
2003-05-15 17:30 UTC, Tom Prado
Details | Diff
Full ebuild for eclipse-SDK-2.1.r1.ebuild (eclipse-SDK-2.1-r1.ebuild,7.11 KB, text/plain)
2003-05-15 17:33 UTC, Tom Prado
Details
Patch to bump ebuild version to 2.1.1 Maintainance Build M20030507 (eclipse-SDK-2.1.1.20030507.ebuild.diff,604 bytes, patch)
2003-05-15 17:50 UTC, Tom Prado
Details | Diff
eclipse-SDK-2.1-r1.ebuild (try 2) (eclipse-SDK-2.1-r1.ebuild,6.61 KB, text/plain)
2003-05-16 12:34 UTC, Tom Prado
Details
dev-util/eclipse-sdk-2.1.1.ebuild (eclipse-sdk-2.1.1.ebuild,7.24 KB, text/plain)
2003-08-06 19:44 UTC, Tom Prado
Details
files/eclipse - launcher script for eclipse (eclipse,1.04 KB, text/plain)
2003-08-06 19:47 UTC, Tom Prado
Details
files/eclipse.desktop (eclipse.desktop,213 bytes, text/plain)
2003-08-06 19:51 UTC, Tom Prado
Details
files/digest-eclipse-sdk-2.1.1 (digest-eclipse-sdk-2.1.1,88 bytes, text/plain)
2003-08-06 19:53 UTC, Tom Prado
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesse 2003-04-14 15:10:49 UTC
I already have eclipse [20030307_rc2] of installed through a normal emerge several weeks 
ago.  Now when I try to 'downgrade' to the _actual_ release: [ebuild    UD] 
dev-util/eclipse-SDK-2.1 it wants to pull in the following: 
 
[ebuild  N   ] dev-libs/libIDL-0.8.0 
[ebuild  N   ] net-libs/linc-1.0.1 
[ebuild  N   ] gnome-base/ORBit2-2.6.1 
[ebuild  N   ] gnome-base/gconf-2.2.0 
[ebuild  N   ] gnome-base/bonobo-activation-2.2.1.1 
[ebuild  N   ] gnome-base/libbonobo-2.2.1 
[ebuild  N   ] gnome-base/gnome-mime-data-2.2.0 
[ebuild  N   ] net-nds/portmap-5b-r7 
[ebuild  N   ] app-admin/fam-oss-2.6.9-r2 
[ebuild  N   ] gnome-base/gnome-vfs-2.2.4 
 
This surely is not intended right?  Why does this new eclipse decide it needs so many 
gnome-specific packages and what's up with installing portmap/fam-oss also?!!
Comment 1 Seemant Kulleen (RETIRED) gentoo-dev 2003-04-14 18:19:52 UTC
you don't have "gnome" in USE do you?
Comment 2 Jesse 2003-04-14 21:20:15 UTC
Here are my USE flags for both the previous version of eclipse-SDK and the most 
recent one: 
 
USE="-gnome -3dnow -arts xfs" 
 
Does '-gnome' count as 'gnome' :)  or did I miss one of those portage messages that 
switched the semantics of USE or something? 
Comment 3 foser (RETIRED) gentoo-dev 2003-04-23 09:13:40 UTC
it just seems the sdk depends on gnome-vfs and that needs all the other deps. -gnome only counts as -gnome when it is _optional_, that doesn't seem to be the case here.

pvdabeel, i assume you added this and have a good reason for this dep ? Please close if appropriate.
Comment 4 Mario Scalas 2003-04-28 14:12:46 UTC
Hmmm ... I commented out the DEPEND about gnome e succesfully emerged it with only 
gtk+ packages. I run & "debugged" a (very) simple project (too simple, perhaps ;) in 
http://www-106.ibm.com/developerworks/opensource/library/os-ecov/ 
It works for me, apart of the horrible fonts it uses (big & blocky). 
Comment 5 foser (RETIRED) gentoo-dev 2003-05-05 20:40:25 UTC
pvdabeel please comment (!)
Comment 6 Tom Prado 2003-05-14 09:42:42 UTC
Hi all, I'm really interested in this particular ebuild because it doesn't use the binary distribution of Eclipse - at least for the ppc target.  It looks like it can use a little more work though because while the ppc target compiles the binary launcher and the swt library, the x86 target grabs the one already supplied.  Also, the supplied jar files are simply copied over to ${D} instead of compiled from their .java source.  If the eclipse-*-bin ebuilds are for the binary version, shouldn't this one be the source version?

I think that this ebuild should compile everything including all the java files and .c files composing Eclipse.  This would be the Gentoo way, would it not?  I've started updating it in my 'overlay' path to compile Eclipse entirely instead of just pulling in all the jars and such.  The eclipse make process uses Ant so I've made that a build dependancy.  

As for the dependancy on gnome-vfs-2*, it appears that the build.csh file that compiles the eclipse binary uses this for some reason.  There's references to pkg-config --libs gnome-vfs-2.0 in there.  I haven't investigated why this is so just yet.

When I have my ebuild changes ready, I'll post them here for your comments.

Does this look like a good direction for this ebuild to you all?

Thanks,
Tom Prado
Comment 7 foser (RETIRED) gentoo-dev 2003-05-14 09:55:22 UTC
i have to say thats the Gentoo way and it sounds good to me. But i'm not the maintainer really, so i don't have the final say on this one.
Comment 8 Tom Prado 2003-05-15 17:30:45 UTC
Created attachment 12038 [details, diff]
Diff for eclipse-SDK-2.1.ebuild (To bring to -r1?)
Comment 9 Tom Prado 2003-05-15 17:33:03 UTC
Created attachment 12039 [details]
Full ebuild for eclipse-SDK-2.1.r1.ebuild
Comment 10 Tom Prado 2003-05-15 17:37:57 UTC
Hi all, here's that ebuild as promised...

Here's a new ebuild for eclipse-SDK.   I'm attaching both a diff and the entire ebuild simply because I ended up rewriting practicly the whole thing.  Here's a rundown of what this new ebuild does:

* Compile all of Eclipse from source code, including the java source for all features.  This applies to all supported architechtures which are sparc, ppc, and x86.  I could only test x86.

* Supports the following USE flags: gtk2, motif, kde, gnome.

    It works as such:  

       USE="-gtk2 -gnome -motif -kde" emerge ....
         ( will compiles for gtk2 only )
 
       USE="-gtk2 gnome -motif -kde" emerge ....
         ( will compiles for both gnome and gtk2 )

       USE="-gtk2 -gnome motif -kde" emerge ....
         ( will compiles for motif only )

       USE="-gtk2 -gnome -motif kde" emerge ....
         ( will compiles for both motif and kde, this is because the kde
           support is supplied by the motif toolkit in Eclipse )

       USE="gtk2 gnome motif kde" emerge ....
         ( compile for everything.  /opt/eclipse/eclipse points to
           the gtk2 version in this case, there is also a /opt/eclipse/eclipse-motif for that version )


The reason I think this should compile from sources is because we have all the -bin ebuilds for eclipse for too.

gerk@gentoo.org & tberman@gentoo.org,  I'm don't know who the maintainer of this ebuild is so I've added you to the CC...


Any comments?  

Thanks!
Tom Prado

Comment 11 Tom Prado 2003-05-15 17:50:11 UTC
Created attachment 12040 [details, diff]
Patch to bump ebuild  version to 2.1.1 Maintainance Build M20030507

This patch is for the eclipse-SDK-2.1-r1.ebuild I just submitted to bump the
Eclipse version to the 2.1.1 Maintainance Build M20030507

I created the original ebuild for 2.1 since that's the released version of
Eclipse but I've been having issues with the gtk version of Eclipse 2.1 (even
the binary) freezing up on me.	This maintainance build seems to fix the issue.
 

Tom Prado
Comment 12 foser (RETIRED) gentoo-dev 2003-05-15 18:09:18 UTC
you shouldnt add random (illegal afaik) email addys.. 

a few points about the ebuild :

it should act on the gtk USE flag, not gtk2 . read the description of the USE flags.

I'm not much into eclipse, but i'm not sure we should go with maintainance builds.

I see a lot of code duplication, that can probably done cleaner.
For the USE flag selection in src_compile, wouldn't some sort of case block not work ? The depend section is maybe a bit overcomplicated. What does kde btw mean ? is that your kde dependancy ?

Since this all from source, there is no need to put it in /opt afaik.

The description mentions 'this is from source', shouldnt be necessary.. gentoo is about being from source, it should only be mentioned if it isn't (and often it is already in the binary names : *-bin )
Comment 13 foser (RETIRED) gentoo-dev 2003-05-15 18:21:05 UTC
oh and it specifically should depend on gtk+-2.2.1-r1 there's a bugfix in there that fixes a freeze bug. Read the ChangeLog .
Comment 14 Tom Prado 2003-05-15 23:29:48 UTC
Thanks for the comments!  

I've cleaned up the ebuild.  I've changed the gtk dependancy back to gtk+-2.2.1-r1, that cleared up my freeze problem too.  Thanks!   I used a case block to make the architecture dependant codes more streamlined.  I fixed the description field.  

I'm working on having it install somewhere else other than /opt/eclipse.  I need to determine where it's configured to look in /opt/eclipse/plugins for the support plugins to be able to move it.  

I removed tberman from the CC list.  Sorry about that.  Don't know what I was thinking.

Now that 2.1 works fine for me with the gtk+ fix, I have no problems sticking with this version and avoiding the maintanence release until it's ready.

The reason for the complex RDEPEND section is because the behaviour I want is this:  The build can depend on either motif or gtk, or both.  If the USE flags are set to -motif and -gtk, I want it to default to gtk.  But if someone doesn't have gtk currently merged because of their -gtk flag, I want to make sure that the DEPEND section will have gtk+ as a dependancy.  I basically want a "!gtk? -and- !motif? ( >=gtk+-2.2.1-r1 ).  Then there's the problem that Eclipse implements kde support within it's motif support.  So if you have +kde, you also need to pull in virtual/motif, which means gtk+ is not required anymore.


Thanks for your help,
Tom Prado
Comment 15 Tom Prado 2003-05-16 12:34:30 UTC
Created attachment 12062 [details]
eclipse-SDK-2.1-r1.ebuild  (try 2)

Here's a new version of the new ebuild.  It includes most of the fixes
suggested.  The only things I haven't done to it yet is move the target from
/opt/eclipse and clean up the RDEPEND section because I don't really know what
to change it to.

To be able to move the install location to, say, /usr/lib/eclipse, would
probably require a wrapper script that would call the binary like the mozilla
build does.  The eclipse binary searchs in it's own directory for the
startup.jar file and the plugins directory.  

This might be a good thing since we can maybe use the script from bug #20740
http://bugs.gentoo.org/show_bug.cgi?id=20740   to do this and also force the
workspace directory to be created somewhere in $HOME as that other bug
mentions.

Tom
Comment 16 foser (RETIRED) gentoo-dev 2003-07-26 14:38:51 UTC
relocation to a team with more time/experience on this one ;)
Comment 17 Tom Prado 2003-08-06 19:44:30 UTC
Created attachment 15646 [details]
dev-util/eclipse-sdk-2.1.1.ebuild

Hi, It's me again.  Attached is an updated ebuild for eclipse-sdk. 
Updates/changes are as follows:

* renamed to eclipse-sdk
* moved install path to /usr/lib/eclipse
* added /usr/bin/eclipse launcher script (attached seperately - taken from bug
#20740 and modified)
* added .eclipseproduct to install path (fixes bug #21380 for the sdk ebuild)
* updated to eclipse 2.1.1
* removed /etc/env.d stuff since there are no libs in the eclipse path, the
eclipse launcher is now in /usr/bin and I don't think the ROOTPATH variable is
needed, it works fine for me without it.
* removed conflicting dependancy from eclipse-bin and eclipse-sdk since this
ebuild now installs to /usr/lib/eclipse.  
* updated files/eclipse.desktop to put it in /usr/share/gnome/apps/Development
so the shortcut appears in gnome2.  (attached separately)

Future enhancements I'd like to add are being able to emerge binary plugins and
have them work with this ebuild.  Well, that's the only enhancement I can think
of right now :-)


Comments?
Tom Prado
Comment 18 Tom Prado 2003-08-06 19:47:49 UTC
Created attachment 15647 [details]
files/eclipse  - launcher script for eclipse

This is a modified version of the launcher script from bug #20740.  It should
go in the portage/dev-utils/eclipse-sdk/files path.
Comment 19 Tom Prado 2003-08-06 19:51:34 UTC
Created attachment 15648 [details]
files/eclipse.desktop

updated eclipse.desktop file for GNOME2.  changed to install in
/usr/share/gnome/apps/Development

also modified to work with gnome-vfs-2.
Comment 20 Tom Prado 2003-08-06 19:53:54 UTC
Created attachment 15651 [details]
files/digest-eclipse-sdk-2.1.1

digest for new eclipse 2.1.1 source .zip file
Comment 21 Tom Prado 2003-08-06 20:00:33 UTC
I tried to change the summary of this bug to "eclipse-sdk 2.1.1 ebuild with updates/bugfixes and builds completely from source" but it wouldn't let me.  This would better reflect what this bug thread has morphed into plus the original bug summary has been addressed by the new attachments contained within.

I haven't attached a ChangeLog since one my comments contain all the changes made.  Let me know if the ChangeLog needs to be attached as well.

Tom
Comment 22 Karl Trygve Kalleberg (RETIRED) gentoo-dev 2003-10-05 14:33:48 UTC
Fixed. Available for testing as dev-util/eclipse-2.1.1. Really excellent
work. We'll probably move it over to dev-eclipse in the near future, and
start adding ebuilds for the various plugins.