Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 193083 - gnome-base/gnome-vfs-2.18.1 patch to prevent showing duplicate volumes using new UUID= and LABEL= shemes in /etc/fstab
Summary: gnome-base/gnome-vfs-2.18.1 patch to prevent showing duplicate volumes using ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] GNOME (show other bugs)
Hardware: All Linux
: High minor
Assignee: Gentoo Linux Gnome Desktop Team
URL: http://bugzilla.gnome.org/show_bug.cg...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-19 16:16 UTC by Yevgen Gorshkov
Modified: 2009-03-08 21:52 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
This adds dereferencing of both UUID= and LABEL= schemes and fixes the issue. (gnome-vfs-2.18.1-no-volume-duplicates.patch,1.95 KB, patch)
2007-09-19 16:21 UTC, Yevgen Gorshkov
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yevgen Gorshkov 2007-09-19 16:16:12 UTC
This patch fixes gnome-vfs issue with parsing /etc/fstab and /proc/mounts entries, using UUID= or LABEL= schemes for referencing partition and showing duplicate entries for volumes.


Reproducible: Always

Steps to Reproduce:
1. Add partition to /etc/fstab with device given by LABEL=<label>, UUID=<uuid> or /dev/disk/by-label/<label> instead of referencing device explicitly and 'user(s)' option enabled, eg.

LABEL=data /media/data ext3 noatime,users,noauto 0 0

or

UUID=3e6be9de-8139-11d1-9106-a43f08d823a6 /media/data ext3 noatime,users,noauto 0 0

2. Open computer:/// address in nautilus


Actual Results:  
All partitions specified as described above will be listed in nautilus twice each (e.g. 'media' and 'media (2)'), referring however to the same partition.


Expected Results:  
Each /etc/fstab entry with option 'user(s)' enabled should be listed once.

More info: https://bugs.launchpad.net/gnome-vfs/+bug/57701

Original patch from Debian Edgy fixes only UUID= scheme and drops out support for referencing partition by label or by symlink. The original patch may also leak memory.
Comment 1 Yevgen Gorshkov 2007-09-19 16:21:54 UTC
Created attachment 131308 [details, diff]
This adds dereferencing of both UUID= and LABEL= schemes and fixes the issue.

Tested on amd64.
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2008-08-25 08:56:11 UTC
Bug still isn't fixed in current trunk (2.23.0+)... Should we apply the patch anyway?

@Team, what say you?
Comment 3 Gilles Dartiguelongue (RETIRED) gentoo-dev 2008-11-29 23:20:20 UTC
I'd say kick upstream to include it, they are still including stuff if it's not too complicated.
Comment 4 Gilles Dartiguelongue (RETIRED) gentoo-dev 2009-03-08 21:52:34 UTC
In 2.24.0-r1. Thanks for the patch and sorry for delay.