can we get the commit list tweaked so it doesnt send a notice about a directory created ? and filter out Manifest commits just like we filter digest commits
Manifest and new directories should be ignored by the mailer already, not sure why they aren't being. Pylon: pingy?
looks like Manifest diffs are ignored, but not newly added Manifests ...
(In reply to comment #2) > looks like Manifest diffs are ignored, but not newly added Manifests ... Yes, new additions are handled differently than modified files. I have to figure out how I can change that behaviour.
No comment since 2007. Not too important?
it's still a bug
Manifest-only commits are ignored by the mailer. The only time that we see the Manifest diff on the commits ML is when repoman commits the Manifest file *with* the rest of the changed contents. That code snippet is: unless ( $files[0] =~ /(Manifest|digest-|userinfo.xml)/i ) { <mail the crap> } But..if we just tell it to always ignore Manifest files, that should work right? $CHANGED_FILE = "$TMPDIR/${FILE_PREFIX}files.changed"; It is 546 lines of perl that I will look at someday but hope that someone else beats me to it :)
Vapier, Could you please update the summary for this bug to state if you are talking about CIA, Mailing lists or other. TIA.
when i add empty dirs to the gentoo-x86 CVS tree, e-mails are sent out to the gentoo-commits mailing list further, i dont think sending out the diff to that list of the Manifest changes are ever useful i imagine the same thing applies to the CIA notification as for where the problem lies, i'll let you guys update the summary as i'm not familiar with the backend pieces
This will be fixed as soon as we migrate to git.
(In reply to Christian Ruppert (idl0r) from comment #9) > This will be fixed as soon as we migrate to git. wooho
