Here is my ebuild submission for Angband, a game that I enjoy quite a bit. A couple of things you might want to note: 1) I don't know if chmod g+s is acceptable with you guys, but I know of no other way to get around the setup that Angband uses for the data directories and save directories. Could be a security issue, I suppose, but it's setting the group to games, and not user to root, so I think it's ok. This works, for me, by making everything in group games, including the angband binary, and then using chmod g+s. 2) The scores.raw file needs to be created root.games so that it won't be owned by anyone except root.games. 3) I probably need to have some of the files in the data directory touched first, but I haven't looked into that yet. After I finish rebuilding from the libpng upgrade, I'll switch to my KDE test user and make sure this *truly* works. ;^) Hope this is worthwhile for you guys.
I tested my ebuild and other users can save games and even read and add to the scoreboard (scores.raw). I think this is usable by others, barring any security issues. However, it would be nice if someone else looked it over for sanity. Also, adding the extra files in .../lib/data at the time of the ebuild may prevent there being any files with ownership foo.games where foo is the user that runs angband for the first time after it is installed. I'll look at this later to see if that can be fixed by touching the right filenames ahead of time.
drobbins: is the chmod g+s acceptable in this ebuild?
I've created an updated ebuild for the recently released Angband 3.0 version. It can be found at the Angband homepage: http://thangorodrim.angband.org/angband-3.0.0-r1.ebuild The new ebuild uses Angband's own installation scripts from the Makefiles and is much simpler and secure than the previous ebuild. All data files that are generated at runtime are touched when installing, so the permissions are correct.
I've tested the new ebuild and it seems to work exactly as advertised. I recommend we go ahead and put Angband into the Portage tree, but then I'm just an addict wanting to inspire more Angband addicts. :^) Thanks, Robert! (For Angband development as well as this ebuild.)
The Angband 3.0.0 ebuild can be updated to 3.0.1 by simply changing the name. I've built it myself and it seems to work just fine.
Firstly, I have seen the same problem as in app-games/zangband (bug #6604), the high score table will get deleted when replacing/upgrading. Then, I didn't meet any problems on PPC, and would vote for adding ppc to KEYWORDS. Find attached my proposal for the 3.0.1 ebuild.
Created attachment 3165 [details] angband-3.0.1.ebuild
committed
