Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 192045 - sys-auth/pam_mount - make better use of pam.eclass
Summary: sys-auth/pam_mount - make better use of pam.eclass
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Hanno Böck
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-10 20:22 UTC by Jakub Moc (RETIRED)
Modified: 2007-09-21 22:43 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
pam_mount-0.19.ebuild.diff (pam_mount-0.19.ebuild.diff,1022 bytes, patch)
2007-09-10 20:24 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2007-09-10 20:22:31 UTC
Patch attached.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-09-10 20:24:21 UTC
Created attachment 130546 [details, diff]
pam_mount-0.19.ebuild.diff

- use dopamsecurity
- econf has its own die message
- add die messages elsewhere
- remove pointless die on dodoc

Thanks. :)
Comment 2 Hanno Böck gentoo-dev 2007-09-19 12:31:19 UTC
dopamsecurity done. I think we had a discussion wheter the e*-functions should always have a || die on the -dev-list some years ago and it was agreed that it should always be there (though I can be wrong if you give me good reasons).

The dodoc || die isn't pointless, it causes dodoc to fail if the docs aren't there - a good qa measure for further updates.
Comment 3 Hanno Böck gentoo-dev 2007-09-19 12:36:17 UTC
was a bit too fast...

your patch for dopamsecurity doesn't work. it requires a subdir in /etc/security to be used, though pam_mount will search in /etc/security for it.

I'm not sure if this function makes sense for that file at all.
Comment 4 Hanno Böck gentoo-dev 2007-09-19 12:37:33 UTC
please give me a working patch or an explaination how dopamsecurity works, else this is resolved for me.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-09-20 09:24:56 UTC
Sorry, this is a working one (the dot is important ;)

dopamsecurity . config/pam_mount.conf.xml || die "dopamsecurity failed

As for the || die, as said, econf has its own die message which is a whole lot more useful than the custom ones, see Bug 48950 Comment #10, and 
Comment 6 Hanno Böck gentoo-dev 2007-09-21 22:43:07 UTC
done