Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 19144 - etc-update doesn't exit with -1
Summary: etc-update doesn't exit with -1
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2003-04-11 09:15 UTC by Martin Holzer (RETIRED)
Modified: 2004-10-22 08:47 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Holzer (RETIRED) gentoo-dev 2003-04-11 09:15:05 UTC
23) /usr/kde/3.1/share/config/ksslcalist
/usr/kde/3.1/share/config/._cfg0000_ksslcalist
Please select a file to edit by entering the corresponding number.
              (-1 to exit) (-3 to auto merge all remaining files)
                           (-5 to auto-merge AND not use 'mv -i'): 

Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file): -1
Below are the new config files for /etc/make.conf:
1) /etc/._cfg0000_make.conf
2) /etc/._cfg0001_make.conf
Please select a file to process (-1 to exit this file):
Comment 1 Nicholas Jones (RETIRED) gentoo-dev 2003-04-28 03:38:15 UTC
fixed in >=48_pre3
Comment 2 Martin Holzer (RETIRED) gentoo-dev 2003-06-24 14:44:31 UTC
same happens with Portage 2.0.48-r1 
Comment 3 Doug Weimer 2004-04-10 09:50:23 UTC
This problem still exists in sys-apps/portage-2.0.50-r3. The problem is in do_file, line 188 on my version. If the user inputs -1, the following holds true:

elif (( ${my_input} == -1 )); then
     return

Unfortunately, the return drops back to the 'until (( ${input} == -1 )); do' loop at 390 and $input is still set to the users previous selection. This causes sel_file() and do_file() to be executed again on the same file. A possible fix is to change the do_file line to:

elif (( ${my_input} == -1 )); then
       input=0                        
       return

This will cause sel_file() to redisplay the original menu.
Comment 4 Masatomo Nakano (RETIRED) gentoo-dev 2004-04-11 05:50:17 UTC
Fixed in CVS
Comment 5 Nicholas Jones (RETIRED) gentoo-dev 2004-10-22 08:47:46 UTC
Bug has been fixed and released in stable portages on or before 2.0.51-r2