Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 191263 - VIDEO_IVTV does not select everything it needs
Summary: VIDEO_IVTV does not select everything it needs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Kernel Bug Wranglers and Kernel Maintainers
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-09-04 16:26 UTC by Doug Goldstein (RETIRED)
Modified: 2007-09-22 14:07 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch to select algobit for ivtv (ivtv_enable_i2c_algobit.patch,1012 bytes, patch)
2007-09-04 21:01 UTC, Mike Pagano
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Doug Goldstein (RETIRED) gentoo-dev 2007-09-04 16:26:05 UTC
When you enable VIDEO_IVTV, it doesn't select everything it needs. drivers/media/video/ivtv/Kconfig needs "select I2C_ALGOBIT" added to it. This has been fixed upstream but do to the nature of the kernel development model, it won't be in the kernel until 2.6.24 so gentoo sources will need this patch until then.
Comment 1 Mike Pagano gentoo-dev 2007-09-04 20:00:50 UTC
Doug,

Is this the commit that you are talking about?
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commit;h=c9b9a5817afc8f969b1ae834f88af6929f70de41

If so, this appears to be in linux v2.6.23-rc1. If that commit looks like the one, would you mind testing the latest vanilla kernel?
Comment 2 Doug Goldstein (RETIRED) gentoo-dev 2007-09-04 20:06:16 UTC
That's it. Hans told me it wouldn't make it in until 2.6.24. No test necessary, I mentioned it to Hans originally.
Comment 3 Mike Pagano gentoo-dev 2007-09-04 21:01:52 UTC
Created attachment 130040 [details, diff]
Patch to select algobit for ivtv

Here's the patch as a possible candidate for back porting to 2.6.22

Doug, would you mind testing the patch against 2.6.22-r6 so we could potentially back port the fix for the .22 kernel?
Comment 4 Mike Pagano gentoo-dev 2007-09-04 21:14:19 UTC
On second thought, it applies against 2.6.22-r6 and performs the necessary addition needed. No need to test.
Comment 5 Maarten Bressers (RETIRED) gentoo-dev 2007-09-17 23:20:44 UTC
Doug, thanks for bringing this to our attention. The patch is in svn, will be included in next version of gentoo-sources. We'll keep this bug open until that's been released.
Comment 6 Daniel Drake (RETIRED) gentoo-dev 2007-09-22 14:07:22 UTC
fixed in genpatches-2.6.22-8 / gentoo-sources-2.6.22-r7