191244 – tetex.eclass filters -Os without replacing with -O2

Bug 191244 - tetex.eclass filters -Os without replacing with -O2

Summary: tetex.eclass filters -Os without replacing with -O2

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	Eclasses (show other bugs)
Hardware:	All Linux

Importance:	High minor (vote)
Assignee:	TeX project

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-09-04 14:41 UTC by Michael Roberts
Modified:	2008-05-12 15:24 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Michael Roberts 2007-09-04 14:41:00 UTC

Line 118-119 of tetex.eclass are:
    # filter -Os; bug #74307.
    filter-flags "-fstack-protector" "-Os"

Since my default CFLAGS use -Os, I end up with no optimization at all when building tetex-3.0_p1-r4.  At the very least, shouldn't -Os be replaced with the safe -O2?

Also, the bug listed in the comment is in no way related to filtering -Os and I could not find any other bugs related to tetex and -Os.

Reproducible: Always

Steps to Reproduce:
1. Set CFLAGS to "-Os"
2. emerge tetex
3.

Actual Results:  
Tetex builds with no optimization.

Expected Results:  
The -Os should either not be stripped or should be replaced with a safer -O2.

Comment 1 Alexis Ballier gentoo-dev

2008-05-12 15:24:28 UTC

changed it, thanks for reporting.
tetex is almost deprecated nowadays, but still there...