Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 19070 - pptpd-1.1.4_beta3 (update)
Summary: pptpd-1.1.4_beta3 (update)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: x86 Linux
: High enhancement (vote)
Assignee: Jared H. Hudson (RETIRED)
URL:
Whiteboard:
Keywords: EBUILD
: 18733 (view as bug list)
Depends on:
Blocks:
 
Reported: 2003-04-10 02:49 UTC by Ross Dougherty
Modified: 2003-06-28 10:17 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
includes new ebuild/conf.d/init.d/digest and config files (pptpd-1.1.4_beta3.tar.gz,2.12 KB, application/x-gzip-compressed)
2003-04-10 02:51 UTC, Ross Dougherty
Details
fixed mistake in pptpd-init (pptpd-init,386 bytes, text/plain)
2003-04-17 18:38 UTC, Ross Dougherty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Ross Dougherty 2003-04-10 02:49:38 UTC
version bump
new/enhanced init script
minor changes to ebuild
Comment 1 Ross Dougherty 2003-04-10 02:51:34 UTC
Created attachment 10456 [details]
includes new ebuild/conf.d/init.d/digest and config files
Comment 2 Ross Dougherty 2003-04-17 18:38:31 UTC
Created attachment 10806 [details]
fixed mistake in pptpd-init

--- pptpd-init.old	2003-04-18 08:36:50.000000000 +1000
+++ pptpd-init	2003-04-18 08:25:37.000000000 +1000
@@ -1,7 +1,7 @@
 #!/sbin/runscript

 depend() {
-	net
+	need net
 }

 start() {
Comment 3 Martin Holzer (RETIRED) gentoo-dev 2003-05-09 17:48:21 UTC
*** Bug 18733 has been marked as a duplicate of this bug. ***
Comment 4 Jared H. Hudson (RETIRED) gentoo-dev 2003-06-28 10:17:34 UTC
Added. In the future, please make sure your ebuild has all the components shown in /usr/portage/skel.ebuild.

For example, your ebuild was missing:
RDEPEND
IUSE
and the Gentoo copyright/GPL header notice

The portage tree contains a app called lintool, which while it's a little outdated it can help you find little errors like those.

Thanks for the ebuild, I just mention these points so that your ebuilds can be even better and so that it will take me and other devs less time to add them, which means I can add even more in less time.