190499 – sys-apps/util-linux-2.13 - includes dep on git

Bug 190499 - sys-apps/util-linux-2.13 - includes dep on git

Summary: sys-apps/util-linux-2.13 - includes dep on git

Status:	RESOLVED FIXED

Alias:	None

Product:	Gentoo Linux
Classification:	Unclassified
Component:	New packages (show other bugs)
Hardware:	All All

Importance:	High normal (vote)
Assignee:	Gentoo's Team for Core System packages

URL:
Whiteboard:
Keywords:

Depends on:
Blocks:

Reported:	2007-08-28 10:45 UTC by adriancz
Modified:	2007-08-28 14:02 UTC (History)
CC List:	0 users

See Also:
Package list:
Runtime testing required:	---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description adriancz 2007-08-28 10:45:22 UTC

Is 

        if [[ ${PV} == "9999" ]] ; then
                git_src_unpack
                cd "${S}"
                ./autogen.sh || die

really needed by util-linux-2.13? I think that util-linux-2.13 doesn't depend on git.


Reproducible: Always

Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev

2007-08-28 12:49:34 UTC

What's wrong with this snippet? ${PV} for util-linux-2.13 is "2.13" so git_src_unpack doesn't even come into effect when you install this version.

Comment 2 Arfrever Frehtes Taifersar Arahesis (RETIRED) gentoo-dev

2007-08-28 12:58:30 UTC

(In reply to comment #1)
> What's wrong with this snippet? ${PV} for util-linux-2.13 is "2.13" so
> git_src_unpack doesn't even come into effect when you install this version.

Unconditional `inherit git` is wrong.

Comment 3 SpanKY gentoo-dev

2007-08-28 14:02:32 UTC

so to answer Lars' question, your questioning of the snippet in src_unpack is wrong

take a minute to actually think about the design and it makes sense