Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 190480 - media-gfx/f-spot doesn't start on ppc due to bad ndesk-dbus library
Summary: media-gfx/f-spot doesn't start on ppc due to bad ndesk-dbus library
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: PPC Linux
: High normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords:
Depends on: 204673
Blocks:
  Show dependency tree
 
Reported: 2007-08-28 08:16 UTC by dario
Modified: 2008-02-24 16:05 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ndesk-dbus fix for f-spot (ndesk-dbus.patch,3.56 KB, patch)
2007-08-28 08:18 UTC, dario
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description dario 2007-08-28 08:16:39 UTC
f-spot embed the ndesk-dbus library (http://www.ndesk.org/DBusSharp), but this code is broken for ppc. There are two fix floating around, but only one worked for me.

1) (from the svn repository) make f-spot using the system ndesk-dbus library if present. The patchs are here: http://svn.gnome.org/viewcvs/f-spot?view=revision&revision=3316. But there isn't still an official ndesk-dbus ebuild, just a proposal http://bugs.gentoo.org/show_bug.cgi?id=159793 that need to be patched.
I tried applying the patch to f-spot but I was not able to link the external library. BTW I'm sure it's my fault.

2) Fix the library directly in f-spot code. I applied the patch I will attach and it worked.

The first solution looks better, make it working and commit to portage tree ;)
Comment 1 dario 2007-08-28 08:18:17 UTC
Created attachment 129441 [details, diff]
ndesk-dbus fix for f-spot
Comment 2 Denis Dupeyron (RETIRED) gentoo-dev 2007-12-27 21:59:47 UTC
I just took over this package and committed a new version. Please test it and tell me if the issue still exist.

Denis.
Comment 3 N. Dan Smith 2008-01-06 19:46:00 UTC
The newer version builds correctly against the dbus-sharp and dbus-glib-sharp ebuilds (thanks to the commit linked in comment #1 which disabled building the bundled dbus-sharp if it is already included).  To fix the problem, on PPC, however, dev-dotnet/dbus-sharp and dev-dotnet/dbus-glib-sharp need to be added as deps.  These currently lack a ~ppc keyword (but I will file a bug and make it block this one).  I am not sure how including the external dbus-sharp lib as a dep will affect building on other arches, however.  Presumably there should be no problem.  From what I gather from Tomboy and f-spot changelogs, bundling dbus-sharp was just a hack for the distros which lack that package.
Comment 4 Denis Dupeyron (RETIRED) gentoo-dev 2008-02-24 16:05:54 UTC
(In reply to comment #3)
> To fix the problem, on PPC,
> however, dev-dotnet/dbus-sharp and dev-dotnet/dbus-glib-sharp need to be added
> as deps.

This should be fixed now because I have committed f-spot-0.4.2 to the tree a few days ago, and in this version those two dependencies are mandatory for everybody. Feel free to reopen if you think I missed something.

Denis.