Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 190206 - games-puzzle/pingus-0.7.1 version bump (unmask too)
Summary: games-puzzle/pingus-0.7.1 version bump (unmask too)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Games (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
: 183983 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-08-25 17:20 UTC by Milan Nikolic
Modified: 2013-03-27 13:50 UTC (History)
12 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
games-puzzle/pingus-0.7.0 ebuild (pingus-0.7.0.ebuild,1.47 KB, text/plain)
2007-08-25 17:21 UTC, Milan Nikolic
Details
patch for resource path (pingus-0.7.0-gentoo-paths.patch,417 bytes, patch)
2007-08-25 17:22 UTC, Milan Nikolic
Details | Diff
games-puzzle/pingus-0.7.0 ebuild (pingus-0.7.0.ebuild,1.48 KB, text/plain)
2007-08-26 15:34 UTC, Milan Nikolic
Details
games-puzzle/pingus-0.7.0 ebuild (pingus-0.7.0.ebuild,1.49 KB, text/plain)
2007-09-02 15:45 UTC, Milan Nikolic
Details
games-puzzle/pingus-0.7.1 (pingus-0.7.1.ebuild,1.57 KB, text/plain)
2007-09-24 10:54 UTC, Milan Nikolic
Details
games-puzzle/pingus-0.7.1.ebuild (pingus-0.7.1.ebuild,1.51 KB, text/plain)
2007-09-25 10:41 UTC, Milan Nikolic
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Milan Nikolic 2007-08-25 17:20:51 UTC
New version of pingus, main change is switch from clanlib to sdl, I created an ebuild and simple patch,and I guess the mask reason doesn't stand anymore since upstream still work on it. Successfully  compiled on x86 and amd64.

Mask reason:
# Michael Sterrett <mr_bones_@gentoo.org> (19 Mar 2007)
# masked for removal when there's a good excuse.
# Old and nasty.  Not supported by upstream.
# use the newer versions of clanlib instead.
# If you find a bug in one of these packages, don't even think
# of filing a bug report unless you have a patch fixing the bug



Reproducible: Always

Steps to Reproduce:
Comment 1 Milan Nikolic 2007-08-25 17:21:45 UTC
Created attachment 129168 [details]
games-puzzle/pingus-0.7.0 ebuild
Comment 2 Milan Nikolic 2007-08-25 17:22:24 UTC
Created attachment 129170 [details, diff]
patch for resource path
Comment 3 Ivan Trombley 2007-08-25 19:17:23 UTC
I get the following sandbox violation with this ebuild:


scons: done building targets.
ACCESS DENIED  open_wr:   /usr/include/SDL/.scons9808
ACCESS DENIED  open_wr:   /usr/include/SDL/.sconsign
>>> Source compiled.
--------------------------- ACCESS VIOLATION SUMMARY ---------------------------
LOG FILE = "/var/log/sandbox/sandbox-games-puzzle_-_pingus-0.7.0-9761.log"

open_wr:   /usr/include/SDL/.scons9808
open_wr:   /usr/include/SDL/.sconsign
--------------------------------------------------------------------------------
!!! This ebuild is from an overlay: '/usr/local/portage'
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2007-08-25 19:29:06 UTC
me too.  scons 0.96.1
Comment 5 Milan Nikolic 2007-08-26 00:49:55 UTC
That has to do with the python-2.5 bug, I do not know the link to the bug but you can search, just emerge -C scons && emerge scons and everything should be ok... and please rename patch, i uploaded file with wrong name :(
Comment 6 Henrique Rodrigues 2007-08-26 12:51:31 UTC
Could you please add the ~ppc keyword to the ebuild? It works great here.
Comment 7 Milan Nikolic 2007-08-26 15:29:23 UTC
Comment on attachment 129168 [details]
games-puzzle/pingus-0.7.0 ebuild

><HTML><HEAD/><BODY><PRE># Copyright 1999-2007 Gentoo Foundation
># Distributed under the terms of the GNU General Public License v2
># $Header: $
>
>inherit eutils games
>
>DESCRIPTION="free Lemmings clone"
>HOMEPAGE="http://pingus.seul.org/"
>SRC_URI="http://pingus.seul.org/files/${P}.tar.bz2"
>
>LICENSE="GPL-2"
>SLOT="0"
>KEYWORDS="~amd64 ~x86 ~ppc"
>IUSE=""
>
>RDEPEND="media-libs/libsdl
>	media-libs/sdl-mixer
>	media-libs/sdl-image
>	media-libs/libpng
>	dev-libs/boost
>	dev-games/physfs"
>	
>DEPEND="${RDEPEND}
>	dev-util/scons"
>
>src_unpack() {
>	unpack ${A}
>	cd ${S}
>	epatch "${FILESDIR}"/pingus-${PV}-path.patch
>}
>
>src_compile() {
>	scons ${MAKEOPTS} CXXFLAGS="${CXXFLAGS}" PREFIX=/usr || die "scons failed"
>}
>
>src_install() {
>	dogamesbin ${PN} || die "dogamesbin failed"
>	dodoc AUTHORS NEWS README TODO || die "dodoc failed"
>
>	cd ${WORKDIR}/${P}/data
>
>	insinto "${GAMES_DATADIR}"/${PN}/data/controller
>	doins controller/*.scm
>	insinto "${GAMES_DATADIR}"/${PN}/data/data
>	doins data/*.res
>	insinto "${GAMES_DATADIR}"/${PN}/data
>	doins -r images/
>	insinto "${GAMES_DATADIR}"/${PN}/data
>	doins -r levels/
>	insinto "${GAMES_DATADIR}"/${PN}/data/music
>	doins music/*.{it,s3m}
>	insinto "${GAMES_DATADIR}"/${PN}/data/po
>	doins po/*.po
>	insinto "${GAMES_DATADIR}"/${PN}/data/sounds
>	doins sounds/*.wav
>	insinto "${GAMES_DATADIR}"/${PN}/data/worldmaps
>	doins worldmaps/*.worldmap		
>
>	# Better than nothing
>	newicon ${WORKDIR}/${P}/data/images/pingus/player0/boarder.png ${PN}.png
>	make_desktop_entry ${PN} Pingus /usr/share/pixmaps/${PN}.png
>	prepgamesdirs
>}
></PRE></BODY></HTML>
Comment 8 Milan Nikolic 2007-08-26 15:32:12 UTC
Comment on attachment 129168 [details]
games-puzzle/pingus-0.7.0 ebuild

added ~ppc keyword
Comment 9 Milan Nikolic 2007-08-26 15:34:56 UTC
Created attachment 129243 [details]
games-puzzle/pingus-0.7.0 ebuild
Comment 10 Mr. Bones. (RETIRED) gentoo-dev 2007-09-02 00:36:19 UTC
*** Bug 183983 has been marked as a duplicate of this bug. ***
Comment 11 kavol 2007-09-02 08:51:54 UTC
(In reply to comment #5)
> just emerge -C scons && emerge scons and everything should be
> ok...

this does not help in my case (amd64) :-(

p.s. Mr. Bones, don't you think that package masking the "bad" version(s) only would be better than to force people to unnecesarily fill their package.unmask; what if another problem in another version comes up so that version should be masked, and it remains unnoticed simply because the program is already unmasked?
Comment 12 Milan Nikolic 2007-09-02 10:45:49 UTC
check this bug http://bugs.gentoo.org/show_bug.cgi?id=107013 ,All Scons ebuilds fail with Sandbox Access Violation Errors , someone reported that just reemerge didn't help, you have to unmerge scons first. I am on amd64 too.
Comment 13 Richie 2007-09-02 14:26:14 UTC
I also had the scons problem described above (My system is AMD64, too). After unmerging scons-0.96.1 and then remerging it the problem remained. I also tried several other suggested solutions that don't work either. Finally I switched to the unstable scons-0.97 and now it works.

As long as pingus-0.7.0 only works with an unstable scons this package should also remain unstable (at least on amd64).
Comment 14 Milan Nikolic 2007-09-02 15:45:54 UTC
Created attachment 129842 [details]
games-puzzle/pingus-0.7.0 ebuild

Added >=scons-0.97, i did all the tests with this version of scons and not realized that with 0.96.1 above solution for Sandbox Access Violation not work.
Comment 15 kavol 2007-09-02 18:29:22 UTC
(In reply to comment #13)
> Finally I switched to the unstable scons-0.97 and now it works.

I can confirm

> As long as pingus-0.7.0 only works with an unstable scons this package
> should also remain unstable (at least on amd64).

I guess this should be done via ~arch rather than package.mask ...
Comment 16 Samuli Suominen (RETIRED) gentoo-dev 2007-09-16 16:34:37 UTC
yay, works for me. good thing upstrema didn't vanish on this one :)
Comment 17 Matija "hook" Šuklje 2007-09-22 21:55:21 UTC
* Scons 0.97 is stable now on amd64
* Pingus 0.7.0 compiles and works fine on amd64 (at least for me)
Comment 18 Matija "hook" Šuklje 2007-09-23 16:39:28 UTC
Pingus just reached 0.7.1.
Comment 19 Matija "hook" Šuklje 2007-09-23 17:10:02 UTC
The resource path patch for 0.7.0 does not work for 0.7.1, but I did find a mentionioning of a --datadir flag in the pingus_main.cpp. Could the same thing be achieved by using --datadir instead of patching?
Comment 20 Milan Nikolic 2007-09-24 10:54:41 UTC
Created attachment 131768 [details]
games-puzzle/pingus-0.7.1

Actually it can, I changed ebuild to use games_make_wrapper function, I hope this is the right way to do it, please test, doesn't need patch anymore.
Comment 21 Matija "hook" Šuklje 2007-09-24 11:22:00 UTC
The 0.7.1 ebuild you made works for me on amd64, but I don't exactly like that the binary is called 'pingus-start'
Comment 22 Milan Nikolic 2007-09-24 11:30:21 UTC
Well, that was the first name that came on my mind, if you or someone else have a better name please say so.
Comment 23 Matija "hook" Šuklje 2007-09-24 11:41:21 UTC
What's wrong with just 'pingus'?

Oh, a script because of the paths? I thought that could be a compile flag, but then again I don't know much about coding.

Erm, never mind then. Although wasn't there a convention a while ago (check, I'm not sure) that in Gentoo such scripts should be named in the form of 'play-pingus'?

Comment 24 Bernard Cafarelli gentoo-dev 2007-09-25 09:27:56 UTC
Another solution could be to install the binary as pingus-bin, and the wrapper as pingus. This works fine here
Comment 25 Matija "hook" Šuklje 2007-09-25 09:32:59 UTC
Bernard's idea ('pingus-bin' as binary and 'pingus' as wrapper) has my vote.
Comment 26 Milan Nikolic 2007-09-25 10:41:58 UTC
Created attachment 131837 [details]
games-puzzle/pingus-0.7.1.ebuild

I also think it is a great idea, here is the modified ebuild, now if only someone will remove the mask and now obsolete version from portage and bump this ebuild instead...
Comment 27 Tristan Heaven (RETIRED) gentoo-dev 2007-09-25 12:50:12 UTC
Fixed, thanks.