Bug 189960 – media-gfx/splashutils-1.5 fails to compile with baselayout-2.0.0_rc3-r1

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Len Meakin 2007-08-23 17:58:40 UTC]

splashutils fails to compile when using baselayout-2.0.0_rc3-r1, please find error info below:

  LD      objs/fbcondecor_helper
  CC      objs/fbcon_decor_ctl.o
  LD      objs/fbcondecor_ctl
cc -march=i686 -O2 -pipe -fomit-frame-pointer -g -Wall -I../core/objs -fPIC -c -o splash.o splash.c
splash.c: In function '_splash_hook':
splash.c:652: error: 'RC_LEVEL_BOOT' undeclared (first use in this function)
splash.c:652: error: (Each undeclared identifier is reported only once
splash.c:652: error: for each function it appears in.)
splash.c:656: error: 'RC_LEVEL_DEFAULT' undeclared (first use in this function)
make: *** [splash.o] Error 1


Reproducible: Always

Steps to Reproduce:
1. Upgrade to baselayout-2
2. emerge -av splashutils
3. Watch as error is produced...

[Comment 1 Len Meakin 2007-08-23 18:00:41 UTC]

Calculating dependencies... done!
[ebuild   R   ] media-gfx/splashutils-1.5  USE="gpm mng png truetype (-hardened)" 0 kB 

Forgot to mention the version (~x86).

[Comment 2 Roy Marples (RETIRED) 2007-08-23 18:45:24 UTC]

The default bootlevel and defaultlevel can be re-defined on the kernel commandline. As such, the defines where removed from rc.h

You get them from the RC_BOOTLEVEL and RC_DEFAULTLEVEL environment variables.

[Comment 3 Jakub Moc (RETIRED) 2007-08-24 15:09:10 UTC]

*** Bug 190052 has been marked as a duplicate of this bug. ***

[Comment 4 Roderick B. Greening 2007-08-24 16:25:09 UTC]

Ok, so splashutils need to be patched to support this new behaviour.

The following lines need to be altered (at the very least) as they are the check for the environment variable, and if not present, use the default... but where to read the default from if removed from rc.h.. guess?

        /* Get boot and default levels from env variables exported by RC.
         * If unavailable, use the default ones. */
        bootlevel = getenv("RC_BOOTLEVEL");
        if (!bootlevel)
                bootlevel = RC_LEVEL_BOOT;

        defaultlevel = getenv("RC_DEFAULTLEVEL");
        if (!defaultlevel)
                defaultlevel = RC_LEVEL_DEFAULT;

[Comment 5 Roderick B. Greening 2007-08-24 16:36:41 UTC]

Created attachment 129080 [details, diff]
Fix check for RC_LEVEL_DEFAULT/BOOT in splashutils for baselayout >= 2.0.0 RC3

[Comment 6 Roderick B. Greening 2007-08-24 16:38:11 UTC]

Attached above is a patch (probably not the best as it hardcodes "default" and "boot" which were previously read from rc.h as defines RC_LEVEL_DEFAULT and RC_LEVEL_BOOT respectively). 

However, it gets the job done and allows the package to compile. If someone want to make a more correct fix, please feel free :)

[Comment 7 Len Meakin 2007-08-25 19:21:53 UTC]

Patch worked for me, Thank you.

[Comment 8 Michal Januszewski (RETIRED) 2007-08-26 19:40:33 UTC]

This problem is fixed in splashutils-1.5.1.