Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 189815 - app-editors/jedit-4.2-r2 -does- did not like jdk-1.6 (patch)
Summary: app-editors/jedit-4.2-r2 -does- did not like jdk-1.6 (patch)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] Java (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Java team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-22 10:03 UTC by Ylosar Goer
Modified: 2007-12-20 10:41 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
jdk-1.6 compat patch (jedit-4.2-jdk-1.6.patch,805 bytes, patch)
2007-08-22 10:04 UTC, Ylosar Goer
Details | Diff
jedit-4.2-r2 update patch (jedit-4.2-r2.patch,653 bytes, patch)
2007-08-22 10:05 UTC, Ylosar Goer
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Ylosar Goer 2007-08-22 10:03:40 UTC
As stated in the current jedit-4.2-r2.ebuild, jedit-4.2 currently does not compile with jdk-1.6 (because of ambigous references to a class named SplashScreen which appeared in jdk-1.6 i think).

I tried to fix this issue and will now attach two patches : the first to replace ambigous references by explicite ones, the second makes the ebuild use the first and updates DEPEND.

They both seem to work for me.
Comment 1 Ylosar Goer 2007-08-22 10:04:30 UTC
Created attachment 128847 [details, diff]
jdk-1.6 compat patch
Comment 2 Ylosar Goer 2007-08-22 10:05:12 UTC
Created attachment 128849 [details, diff]
jedit-4.2-r2 update patch
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2007-08-22 10:05:30 UTC
(In reply to comment #1)
> Created an attachment (id=128847) [edit]
> jdk-1.6 compat patch
> 

Please submit this to jedit upstream and post the url back here. This way we are not stuck maintaining this patch.
Comment 4 Ylosar Goer 2007-08-22 10:47:11 UTC
(In reply to comment #3)
> Please submit this to jedit upstream and post the url back here.

Well i can try if you insist, but i am quiet sure that they will ignore my request as they already fixed this a long time ago by tweaking import statements [1].

Their answer will be "use jdk-1.4 or jdk1.5 to compile jedit-4.2, or go with jedit-4.3pre10", don't you think ?

1. http://jedit.svn.sourceforge.net/viewvc/jedit/jEdit/trunk/org/gjt/sp/jedit/GUIUtilities.java?r1=5317&r2=5345
Comment 5 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2007-08-22 11:06:42 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > Please submit this to jedit upstream and post the url back here.
> 
> Well i can try if you insist, but i am quiet sure that they will ignore my
> request as they already fixed this a long time ago by tweaking import
> statements [1].

Guess we didn't know that, we wouldn't ask to submit your patch upstream otherwise. Of course, looking if the problem is already fixed in CVS/betas before submitting is wise, glad you did.

> Their answer will be "use jdk-1.4 or jdk1.5 to compile jedit-4.2, or go with
> jedit-4.3pre10", don't you think ?

Sure we don't expect them to fix 4.2, the point was so that we don't have to keep patching future versions. Seems we won't then, fine. 
Comment 6 Vlastimil Babka (Caster) (RETIRED) gentoo-dev 2007-12-20 10:41:32 UTC
4.3pre11 was added some time ago which doesn't have this problem anymore. Anyway, I've also applied your patch to 4.2-r2 because it's current stable. Thanks!