Bug 189334 – net-p2p/kmldonkey brings up failed dialog unecessarily

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description pTeppic 2007-08-18 10:01:40 UTC]

When submitting ed2k links from Konqueror kmldonkey always opens the 'Failed to submit link' message dialog, even if the detailed message is that the link was added successfully.

Reproducible: Always

Steps to Reproduce:
1.Find ed2k link
2.Follow from Konqueror
3.Allow Konqueror to follow the link

Actual Results:  
Link added by client, but 'Failed to submit link' message dialog appears.

Expected Results:  
Link added by client and no error message.

A patch to fix is below.

--- ./src/scripts/submit.cpp.orig       2005-07-26 17:40:40.000000000 +0100
+++ ./src/scripts/submit.cpp    2007-08-18 10:04:14.000000000 +0100
@@ -48,7 +48,7 @@
 {
     kdDebug() << "Callback cmd: " << cmd << endl;
     kdDebug() << "Callback result: " << res << endl;
-    if (res.lower() != "done" && !res.contains("parsing http url", false)) {
+    if (!res.contains("Added link", false)) {
        /*
        if (res.contains("force_download")) {
            if (KMessageBox::warningYesNo(0, i18n("Failed to submit URL %1\n\nForce download?")

[Comment 1 Jakub Moc (RETIRED) 2007-08-18 11:43:33 UTC]

Submit this upstream, please. Not a Gentoo bug.

[Comment 2 Wulf Krueger (RETIRED) 2007-09-01 23:32:37 UTC]

I've contacted upstream about this to find out if he's even still maintaining kmldonkey.

[Comment 3 Wulf Krueger (RETIRED) 2007-09-02 21:58:59 UTC]

As I expected, upstream informed me that kmldonkey is unmaintained. I've added the patch and it works for me but if further problems arise, this package might leave the tree.

Nevertheless: Thanks for the patch, pTeppic!