Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 189118 - sci-astronomy/ds9 depends on emacs
Summary: sci-astronomy/ds9 depends on emacs
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Science Related Packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-16 15:20 UTC by Kirill Sokolovsky
Modified: 2008-03-24 22:05 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Remove the emacs dependency entirely (ds9-5.1.ebuild-no_etags.patch,1.20 KB, patch)
2008-02-19 00:59 UTC, Henry Gebhardt
Details | Diff
Remove TAGS from "all" make target (ds9-5.1.ebuild.patch,524 bytes, patch)
2008-03-22 14:09 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kirill Sokolovsky 2007-08-16 15:20:58 UTC
sci-astronomy/ds9 ebuild needs etags command, which is part of app-editors/emacs. If app-editors/emacs is not present in the system ds9 fails to emerge. It would be nice if somebody could write this dependency into sci-astronomy/ds9 ebuild. :)

Reproducible: Always

Steps to Reproduce:
1. make shure etags command is not present in $PATH (ie app-editors/emacs is not installed)
2. emerge sci-astronomy/ds9
Comment 1 Ulrich Müller gentoo-dev 2007-08-16 20:59:23 UTC
etags is provided by both GNU Emacs and XEmacs, so the (build-time) dependency should probably be something like: || ( virtual/emacs virtual/xemacs )
Comment 2 Sébastien Fabbro (RETIRED) gentoo-dev 2007-08-17 09:56:59 UTC
fixed, thanks all.
Comment 3 Henry Gebhardt 2008-02-19 00:59:18 UTC
Created attachment 143928 [details, diff]
Remove the emacs dependency entirely
Comment 4 Christian Faulhammer (RETIRED) gentoo-dev 2008-02-19 07:38:38 UTC
(In reply to comment #3)
> Created an attachment (id=143928) [edit]
> Remove the emacs dependency entirely

 Can you state a reason?  Apart from people not wanting Emacs.  Is the functionality crippled without etags?

Comment 5 Henry Gebhardt 2008-02-19 19:56:32 UTC
(In reply to comment #4)
>  Can you state a reason?  Apart from people not wanting Emacs.

No, I just don't want 100Mb of Emacs. So this is merely an unimportant enhancement. Sorry for any inconvenience.

> Is the
> functionality crippled without etags?

No. The resulting installation is the same, although I noticed that the /usr/bin/ds9 binary has a different md5sum after every compile (independent of etags). The size stays exactly the same, my CFLAGS="-Wall -O2 -march=pentium4m -pipe", so should be safe.

In any case I don't notice a difference when I run ds9. Thanks.
Comment 6 Ulrich Müller gentoo-dev 2008-03-22 14:09:02 UTC
Created attachment 146899 [details, diff]
Remove TAGS from "all" make target

Henry, could you please test if attached (less intrusive) approach also works?
Comment 7 Henry Gebhardt 2008-03-24 22:05:29 UTC
Hi, thanks for the patch. I don't use ds9 extensively anymore, but basic tasks as well as basic XPA-commands work very well. I certainly don't notice a difference running it.

However, I did notice that the size of the /usr/bin/ds9 binary differs by 2 bytes: 10297167 with etags versus 10297169 with your patch. My CFLAGS currently are "-march=pentium3 -msse2 -O2 -pipe" on a pentium4m (some of my numerical apps are noticably faster that way, weird...), so it could be related to that.

Of course, the md5sum is still different after each compile, but that is independent of any patches presented here.

Also, there was a segmentation fault when closing the "ROSAT All-Sky (MPE/MPG)" Archive, but it doesn't always occurr. In any case, I doubt it was related to this bug, as it occurred multiple times with etags as well as with your patch.