Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 189018 - Allow custom patches for www-servers/apache
Summary: Allow custom patches for www-servers/apache
Status: RESOLVED WONTFIX
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Apache Team - Bugzilla Reports
URL:
Whiteboard:
Keywords:
: 196535 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-08-15 16:28 UTC by Michael Hanselmann (hansmi) (RETIRED)
Modified: 2009-04-04 06:10 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch implementing APACHE_PATCH_DIR (apache-custom-patches.diff,729 bytes, patch)
2007-08-15 16:29 UTC, Michael Hanselmann (hansmi) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2007-08-15 16:28:42 UTC
I've been maintaining my own, local Apache ebuild for years. The main reason was that I wanted things in other places and the configuration needs special patches. While the first can be easily circumented by moving to Gentoo's default layout, the second one isn't. I added a variable to mail-mta/netqmail which can point to a directory of custom patches to be applied (QMAIL_PATCH_DIR) and it works beautifully there. The file attached to this bug contains a diff doing the same for the latest Apache ebuild. It would be great if it could be added because then I could give up on my own ebuild.
Comment 1 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2007-08-15 16:29:26 UTC
Created attachment 128190 [details, diff]
Patch implementing APACHE_PATCH_DIR
Comment 2 Christian Parpart (RETIRED) gentoo-dev 2007-08-16 13:07:30 UTC
why not adding this as a feature globally - so that (in theory) *any* ebuild could make use of it.

so we would need a central place the ebuild is looking at, for example:

/etc/portage/patches/CATEGORY/PACKAGE/*

and standard pkg_unpack() could load ecustompatch, which *could* look like this:

ecustompatch() {
    if [[ -f /etc/portage/patches/CATEGORY/${PN}/* ]]; then
        ewarn "WARN THE USER HERE - just like the notice you proposed."
        epatch "/etc/portage/patches/CATEGORY/${PN}"/* || die "..."
    fi
}

i would prefer this way, and i guess lots of (power) users would appreciate it.

maybe CC portage devs about it?
Comment 3 Christian Heim (RETIRED) gentoo-dev 2007-08-16 14:17:28 UTC
(In reply to comment #2)
> why not adding this as a feature globally - so that (in theory) *any* ebuild
> could make use of it.
> 
> so we would need a central place the ebuild is looking at, for example:
> 
> /etc/portage/patches/CATEGORY/PACKAGE/*
> 
> and standard pkg_unpack() could load ecustompatch, which *could* look like
> this:
> 
> ecustompatch() {
>     if [[ -f /etc/portage/patches/CATEGORY/${PN}/* ]]; then
>         ewarn "WARN THE USER HERE - just like the notice you proposed."
>         epatch "/etc/portage/patches/CATEGORY/${PN}"/* || die "..."
>     fi
> }
> 
> i would prefer this way, and i guess lots of (power) users would appreciate it.
> 
> maybe CC portage devs about it?

They're going to say the same as I would ... Use /etc/portage/bashrc, since it's already doable with that.
Comment 4 Michael Hanselmann (hansmi) (RETIRED) gentoo-dev 2007-08-16 15:41:53 UTC
(In reply to comment #3)
> They're going to say the same as I would ... Use /etc/portage/bashrc, since
> it's already doable with that.

/etc/portage/bashrc allows only hooks before something is done, not after it. Patching the code on EBUILD_PHASE=compile isn't clean.
Comment 5 Marius Mauch (RETIRED) gentoo-dev 2007-08-16 18:18:27 UTC
(In reply to comment #4)
> (In reply to comment #3)
> > They're going to say the same as I would ... Use /etc/portage/bashrc, since
> > it's already doable with that.
> 
> /etc/portage/bashrc allows only hooks before something is done, not after it.

Incorrect. Use post_src_unpack().
Comment 6 Jakub Moc (RETIRED) gentoo-dev 2007-10-20 15:19:06 UTC
*** Bug 196535 has been marked as a duplicate of this bug. ***