Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 188725 - app-admin/syslog-ng initscript breaks dependency caching w/ baselayout-2
Summary: app-admin/syslog-ng initscript breaks dependency caching w/ baselayout-2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Mr. Bones. (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-13 15:55 UTC by Jakub Moc (RETIRED)
Modified: 2007-10-02 23:02 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Jakub Moc (RETIRED) gentoo-dev 2007-08-13 15:55:21 UTC
<snip>
case $(sed 's/#.*//' /etc/syslog-ng/syslog-ng.conf) in
        *source*tcp*|*source*udp*|*destination*tcp*|*destination*udp*)
                need net ;;
esac
</snip>

No go; baselayout compares the mtime of the deptree with /etc/{conf,init}.d, not with in any other files outside those.
Comment 1 Mr. Bones. (RETIRED) gentoo-dev 2007-08-13 16:28:29 UTC
patches welcome.
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-08-13 16:30:18 UTC
(In reply to comment #1)
> patches welcome.

Well, the patch is pretty trivial, set REMOTE_LOGGING=[yes|no] or whatever similar in /etc/conf.d/syslog.ng and use this value in initscript for dependencies. It can't use any dynamic content in files that baselayout doesn't care about.
Comment 3 Roy Marples (RETIRED) gentoo-dev 2007-08-16 11:30:25 UTC
baselayout-2.0.0_rc3 will allow the following

depend() {
   config /etc/fstab
}

Which means it will update the dependency tree if the mtime of fstab is newer than the mtime of the deptree.

So when baselayout-2 is stable, whack that in the init script.
Comment 4 Mr. Bones. (RETIRED) gentoo-dev 2007-08-16 15:49:10 UTC
How does the mtime of /etc/fstab relate to this bug?  This smells like a dirty hack.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-08-16 15:58:54 UTC
(In reply to comment #4)
> How does the mtime of /etc/fstab relate to this bug?  This smells like a dirty
> hack.

Should be  

config /etc/syslog-ng/syslog-ng.conf

here. Uberlord was referring to /etc/init.d/netmount, which has the same problem.
Comment 6 Mr. Bones. (RETIRED) gentoo-dev 2007-08-16 16:04:01 UTC
What does the mtime of /etc/syslog-ng/syslog-ng.conf have to do with the deps for the service?
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-08-16 16:09:27 UTC
(In reply to comment #6)
> What does the mtime of /etc/syslog-ng/syslog-ng.conf have to do with the deps
> for the service?

Already described once in Comment #0; baselayout won't update the dependencies if you edit etc/syslog-ng/syslog-ng.conf, so your case $(sed ...) fu in depend() won't work ATM - simply because baselayout doesn't check the mtime anywhere but in /etc/{conf,init}.d
Comment 8 Mr. Bones. (RETIRED) gentoo-dev 2007-10-02 23:02:46 UTC
Kludge in CVS for baselayout-1 and baselayout-2 support suggested by uberlord.