Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 188700 - [stable] net-misc/vconfig-1.9 (baselayout review)
Summary: [stable] net-misc/vconfig-1.9 (baselayout review)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: [OLD] baselayout (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Peter Volkov (RETIRED)
URL:
Whiteboard:
Keywords: STABLEREQ
Depends on:
Blocks:
 
Reported: 2007-08-13 12:03 UTC by Peter Volkov (RETIRED)
Modified: 2007-11-06 00:45 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Peter Volkov (RETIRED) gentoo-dev 2007-08-13 12:03:15 UTC 
net-misc/vconfig-1.9 should been stabilized long time ago... The change between versions is only return codes.

But before stabilization I'd like somebody more familiar with baselayout confirm, that this change should not pose any regressions. Do you rely on return codes? To simplify check I've put relevant diff here: http://dev.gentoo.org/~pva/vconfig-1.8-1.9.patch Thank you.
Comment 1 Roy Marples (RETIRED) gentoo-dev 2007-08-13 12:13:23 UTC 
We don't check the return code for this very reason!

Actually this would make our code a lot easier if we could check the return code :)
Comment 2 Peter Volkov (RETIRED) gentoo-dev 2007-08-13 13:11:13 UTC 
Great. I've looked at the code another time and seems that after net-misc/vconfig-1.9 stabilization and cleaning 1.8 it'll become possible to simplify baselayouts code...

And now, arch teams, please, stabilize net-misc/vconfig-1.9.
Comment 3 Gustavo Zacarias (RETIRED) gentoo-dev 2007-08-13 13:42:03 UTC 
sparc stable.
Comment 4 Markus Ullmann (RETIRED) gentoo-dev 2007-08-21 07:52:18 UTC 
" * 802.1Q VLAN support is now in the linux kernel as of 2.4.14."

I think that can safely be dropped, right?

Stable on x86
Comment 5 Chris Gianelloni (RETIRED) gentoo-dev 2007-11-06 00:45:04 UTC 
amd64 done... we're last, so marking as FIXED