Bug 188099 – Specifying livecd/volid on commandline makes string twice its size

• Status: RESOLVED FIXED
• Product: Gentoo Hosted Projects

[Description Tais P. Hansen 2007-08-08 12:32:17 UTC]

If I run catalyst with -C livecd/volid="Gentoo Linux" the resulting volumeid will become "G e n t o o  L i n u x". Seems like the string.join() call in set_iso_volume_id() (in generic_stage_target.py) is causing this.

[Comment 1 Tais P. Hansen 2007-08-08 12:50:23 UTC]

Created attachment 127276 [details, diff]
Patch to allow specifying volid on commandline

[Comment 2 Andrew Gaffney (RETIRED) 2007-08-08 13:37:11 UTC]

I'm not sure that livecd/volid should ever be a list anyway. AFAIK, an ISO can only have 1 volume ID. I'd rather just get rid of the call to string.join()

[Comment 3 Chris Gianelloni (RETIRED) 2007-08-29 17:31:32 UTC]

So just remove the one line or... ?

[Comment 4 Andrew Gaffney (RETIRED) 2007-08-29 18:05:58 UTC]

Just change it to:

self.settings["iso_volume_id"] = self.settings[self.settings["spec_prefix"]+"/volid"]

[Comment 5 Chris Gianelloni (RETIRED) 2007-08-29 18:13:08 UTC]

OK.  I fixed this in SVN.

[Comment 6 Chris Gianelloni (RETIRED) 2007-08-29 18:23:01 UTC]

This is now in catalyst 2.0.5_pre2 and ready for testing.