Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 187882 - media-libs/flac-1.2.0 doesn't compile with USE="-ogg"
Summary: media-libs/flac-1.2.0 doesn't compile with USE="-ogg"
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal (vote)
Assignee: Gentoo Sound Team
URL: http://flac.cvs.sourceforge.net/flac/...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-06 07:55 UTC by marty rosenberg
Modified: 2007-08-06 11:12 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description marty rosenberg 2007-08-06 07:55:50 UTC
Not really gentoo specific, unless this is a problem caused by a gentoo patch.
in flac-1.2.0/src/flac/encode.c, on line 2181, 

if(e->use_ogg && e->total_samples_to_encode > 0 && e->total_samp
les_to_encode / e->sample_rate / 10 > 230)

should be

if(
#if FLAC__HAS_OGG
e->use_ogg &&
#endif
 e->total_samples_to_encode > 0 && e->total_samp
les_to_encode / e->sample_rate / 10 > 230)

or something else equivalent.  Personally, I think that the 'changing contents of if statement based on compile time flags' is disgusting, but whatever.
Comment 1 Samuli Suominen (RETIRED) gentoo-dev 2007-08-06 10:45:43 UTC
(In reply to comment #0)
> Not really gentoo specific, unless this is a problem caused by a gentoo patch.
> in flac-1.2.0/src/flac/encode.c, on line 2181, 

It's not because of our patches but definately a problem, thanks.. looking at it.
Comment 2 Samuli Suominen (RETIRED) gentoo-dev 2007-08-06 11:12:46 UTC
Applied upstream patch fixing this. Thanks again for reporting :)