Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 187725 - app-arch/p7zip remove hardcoded -mcpu flags
Summary: app-arch/p7zip remove hardcoded -mcpu flags
Status: RESOLVED INVALID
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Radoslaw Stachowiak (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-08-04 13:14 UTC by Michael Kefeder
Modified: 2007-08-04 18:36 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Kefeder 2007-08-04 13:14:43 UTC
When compiling p7zip with gcc >4.0 it spews out warnings about -mcpu being a deprecated flag. I think we should replace it in the makefile. 

What i did and worked out nicely was adding the following

-e "s/mcpu/mtune/g" \

to the existing sed command in the ebuild. It actually needs a more elaborate solution doing the right thing for the right compiler, that's why i don't include a diff for my changes.


Reproducible: Always
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-08-04 13:22:36 UTC
Nah, it shouldn't harcode either for them.
Comment 2 Radoslaw Stachowiak (RETIRED) gentoo-dev 2007-08-04 13:39:01 UTC
Silly me, but I wasn't able to find any mcpu occurence in p7zip 4.51 sources (except for innocent similarities in LZMA sourcecode).

Could you please point me to exact makefile where it exists?

Or maybe it was older version?
Comment 3 Michael Kefeder 2007-08-04 18:36:03 UTC
You are right there's no mcpu in the makefiles, but adding this sed line made the warnings go away. I am sorry i haven't checked the makefiles, i just applied a quickfix i thought should work to the ebuild, tried it and it worked - that's why i submitted it here.

Building p7zip definitely uses -mcpu=i686 here, I wonder where that is coming from (my CFLAGS are -march=athlon-xp -pipe), I suspect old gentoo defaults or something. I'll check my environment for mcpu stuff, seems to be my fault somehow, sorry for the inconvenience I've caused.