The "elogviewer" python script will parse every filename in the ELOG directory, as it expects a filename format like *:*:*.log if a file like "summary.log" is found the script will crash. Reproducible: Always Steps to Reproduce: 1. Put any file with non-standard filename format in the ELOG dir 2. Run elogviewer Actual Results: elogviewer crashes Expected Results: Elogviewer should at least not crash as "save_summary" is an official elog feature. (As an addictional feature elogviewer could also parse the summary.log file.)
Created attachment 126808 [details, diff] A possible patch This is a possible patch. My Python skill are terrible, but this seems to work. It parses the os.listdir and every file with non-standard *:*:* filename are excluded.
Adding the author of the software...
It seems as author has opened a new account on Bugzilla, adding him.
Thanks a lot for your patch...I did not apply it earlier as I wanted to give upstream time to fix it and release a new version. Meanwhile I discovered elogv has the same problem, at least 0.5.1 currently in the tree, 0.6.0 available so I will test there. kelogviewer is being emerged right now. Again thanks.
Luca, adding you as author of elogv. See comment #4, and don't hesitate to inform me about new versions, I check very seldom.
kelogviewer is not affected, reopening for elogv
Created attachment 130660 [details, diff] A possible patch for elogv I had some spare time and I wanted to do something usefull so I "ported" my "patch" to elogv (just a couple of lines). It seems to work but I didn't test it a lot because I don't use elogv. Hope this helps you. Thanks for your hard work: I do really enjoy my gentoo system.
(In reply to comment #4) > Thanks a lot for your patch...I did not apply it earlier as I wanted to give > upstream time to fix it and release a new version. Oh yes, sorry... I have been working on it a bit on my spare, which I don't have much... I am removing the regexp from elogviewer (I don't know that too well) and will use glob.glob to fix it. At some point, I'll try to parse summary.log as well... Thanks for caring.
Mathias, we all volunteer so no accusation intended. It is fixed and that's fine to me, just wanted to motivate some of you. :) Radice, thank you for your support, as my Python skills are baaaad. But please provide patches in unified format, makes it easier to apply if codebase has changed. Closing and I will file a stabilisation request as the current stable Portage (for some days) will have save_summary on by default, rendering the elogviewer unusable.
Sorry for the patch format... thanks for the suggestion. :-)
(In reply to comment #5) > Luca, adding you as author of elogv. See comment #4, and don't hesitate to > inform me about new versions, I check very seldom. > Hi at all, I have released a new version 0.6.1 that solves the issue, please try it. ok, I will notify you for future versions. ;)
(In reply to comment #11) > I have released a new version 0.6.1 that solves the issue, please try it. ok, I > will notify you for future versions. ;) In the tree.
