Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 187555 - media-sound/qmpdclient-1.0.8 - add 'dbus' use flag
Summary: media-sound/qmpdclient-1.0.8 - add 'dbus' use flag
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor (vote)
Assignee: Gentoo Sound Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 168964
  Show dependency tree
 
Reported: 2007-08-02 22:47 UTC by Davide Pesavento
Modified: 2009-04-06 11:33 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
qmpdclient-1.0.8.ebuild.patch (qmpdclient-1.0.8.ebuild.patch,1.89 KB, patch)
2007-08-02 22:48 UTC, Davide Pesavento (RETIRED)
Details | Diff
qmpdclient-no-dbus.patch (qmpdclient-no-dbus.patch,738 bytes, patch)
2007-08-02 22:48 UTC, Davide Pesavento (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Davide Pesavento (RETIRED) gentoo-dev 2007-08-02 22:47:35 UTC
media-sound/qmpdclient-1.0.8 forcefully compiles dbus notifications if it detects than qt4 has been compiled with USE="dbus". This cannot actually be disabled because qmpdclient ebuild is missing 'dbus' flag in IUSE.
The following patches implement this new flag. Ebuild has also been changed to use eqmake4 from qt4.eclass rather than manually invoking qmake.
Comment 1 Davide Pesavento (RETIRED) gentoo-dev 2007-08-02 22:48:10 UTC
Created attachment 126757 [details, diff]
qmpdclient-1.0.8.ebuild.patch

Ebuild patch.
Comment 2 Davide Pesavento (RETIRED) gentoo-dev 2007-08-02 22:48:45 UTC
Created attachment 126758 [details, diff]
qmpdclient-no-dbus.patch
Comment 3 Davide Pesavento (RETIRED) gentoo-dev 2007-08-31 20:20:25 UTC
Ping!
Comment 4 Andrej Kacian (RETIRED) gentoo-dev 2007-09-30 15:03:58 UTC
Have you submitted the patch for qmpdclient.pro upstream?
Comment 5 Davide Pesavento (RETIRED) gentoo-dev 2007-09-30 16:43:42 UTC
Nope. I don't think upstream will accept that patch anyway, because it is applied conditionally depending on 'dbus' USE flag, which is gentoo-specific of course ;)
I don't think that a more general patch may be created because of intrinsic qmake limitations. A possible (but very invasive) solution would be writing a configure script which should be run before qmake invocation and will generate a file containing the desired configuration that should be then included by a patched version of qmpdclient.pro. The configure script will accept --enable-dbus-notifications and/or --disable-dbus-notifications like traditional configure scripts.
Comment 6 Łukasz Damentko (RETIRED) gentoo-dev 2008-05-27 13:11:16 UTC
Ticho was retired (#59986), reassigning remaining bugs to the herd.
Comment 7 Markos Chandras (RETIRED) gentoo-dev 2009-04-06 11:33:37 UTC
Hmm, one year old buggie :) 
Latest qmpclient-1-1.0 requres qt-gui[dbus].

I am closing it . Re-open if needed