Bug 186947 – app-admin/conky-1.4.5 uses bundled libmpdclient

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description fow 2007-07-28 23:18:15 UTC]

app-admin/conky-1.4.5 says it needs media-sound/mpd when the mpd USE flag is set. This works, however conky will work without it as conky includes libmpdclient in its distribution.

Reproducible: Always

Steps to Reproduce:
1. emerge app-admin/conky-1.4.5
2. run conky with a config with MPD variables
3. unmerge media-sound/mpd
4. run conky again

Actual Results:  
conky will run the same way during steps 2 and 4

Expected Results:  
conky to somehow mess up during step 4

[Comment 1 fow 2007-07-28 23:19:06 UTC]

Created attachment 126282 [details, diff]
removes the mpd RDEPEND line

[Comment 2 Jakub Moc (RETIRED) 2007-07-29 06:39:35 UTC]

Uhm, using bundled stuff is baaad, mkay... :P

[Comment 3 fow 2007-07-29 18:53:38 UTC]

I agree. I started this bug thinking it needed media-libs/libmpd, then I tested it and got confused when it worked with neither media-sound/mpd nor media-libs/libmpd. Either way, media-sound/mpd shouldn't be a dep.

[Comment 4 Stan Behrens 2007-08-01 19:28:34 UTC]

MPD's protocol is that simple that conky don't need to require any external lib for that.

Example:
$ echo status | nc 127.0.0.1 6600
OK MPD 0.13.0
volume: 72
repeat: 0
random: 0
playlist: 4202
playlistlength: 115
xfade: 0
state: play
song: 42
songid: 4127
time: 542:4348
bitrate: 192
audio: 44100:16:2
OK


So in my opinion removing this false-dependency is the right way ...

[Comment 5 Brenden Matthews 2007-08-01 19:34:04 UTC]

(In reply to comment #4)
> MPD's protocol is that simple that conky don't need to require any external lib
> for that.
> 
> Example:
> $ echo status | nc 127.0.0.1 6600
> OK MPD 0.13.0
> volume: 72
> repeat: 0
> random: 0
> playlist: 4202
> playlistlength: 115
> xfade: 0
> state: play
> song: 42
> songid: 4127
> time: 542:4348
> bitrate: 192
> audio: 44100:16:2
> OK
> 
> 
> So in my opinion removing this false-dependency is the right way ...
> 

Agreed.  I brought this up before, but it didn't happen for some reason...

[Comment 6 fow 2007-08-03 04:32:34 UTC]

(In reply to comment #4)
> So in my opinion removing this false-dependency is the right way ...

While that may be true about the MPD protocol, conky does indeed use libmpd:

snaxe@deskbert ~ $ tar tvjf /usr/portage/distfiles/conky-1.4.5.tar.bz2 | grep libmpdclient
-rw-r--r-- 1000/100      39416 2006-11-21 15:08 conky-1.4.5/src/libmpdclient.c
-rw-r--r-- 1000/100      15818 2006-11-21 15:08 conky-1.4.5/src/libmpdclient.h

[Comment 7 Christian Faulhammer (RETIRED) 2007-08-07 06:56:31 UTC]

version bump done