Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 186854 - media-video/mplayer-1.0.20070622-r[123] doesn't depend on libdts
Summary: media-video/mplayer-1.0.20070622-r[123] doesn't depend on libdts
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement
Assignee: Gentoo Media-video project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-28 01:12 UTC by David Watzke
Modified: 2007-08-15 06:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Watzke 2007-07-28 01:12:49 UTC
media-video/mplayer-1.0.20070622-r[12] compiles against libdca 0.0.5 (libdts successor) too, so please change DEPEND.

<       dts? ( media-libs/libdts )
---
>       dts? ( || ( media-libs/libdts media-libs/libdca ) )

Thanks.
Comment 1 Steve Dibb (RETIRED) gentoo-dev 2007-07-28 22:45:27 UTC
p.masked

# Alexis Ballier <aballier@gentoo.org> (18 Apr 2007)
# New version and new name for media-libs/libdts
# It has an api compatibility layer but some packages
# try to link using -ldts which just fails
media-libs/libdca
Comment 2 David Watzke 2007-07-28 22:49:17 UTC
Yes, I know. Is that a problem? On systems where media-libs/libdca isn't unmasked it just selects libdts.
Comment 3 Alexis Ballier gentoo-dev 2007-07-29 11:28:16 UTC
seems more like it uses ffmpeg's dts decoder now rather than libdca or libdts
grepping in mplayer's source tree didn't show me any checks for libdts nor libdca
Comment 4 David Watzke 2007-07-29 14:06:25 UTC
Yeah, you're right, it compiles even without one of these. Changing summary.
Comment 5 Steve Dibb (RETIRED) gentoo-dev 2007-07-29 14:09:34 UTC
Actually, I think DTS is currently broken in this release anyway.
Comment 6 Steve Dibb (RETIRED) gentoo-dev 2007-08-15 03:24:56 UTC
reopen when the package is unmasked
Comment 7 David Watzke 2007-08-15 04:25:06 UTC
(In reply to comment #6)
> reopen when the package is unmasked

okay, but could you please remove the useless dts flag (and the libdts dependency) from the ebuild?
Comment 8 Steve Dibb (RETIRED) gentoo-dev 2007-08-15 06:24:58 UTC
(In reply to comment #7)
> (In reply to comment #6)
> > reopen when the package is unmasked
> 
> okay, but could you please remove the useless dts flag (and the libdts
> dependency) from the ebuild?
> 

Hmm, svn is still building against it, but there's definately a check for libdca.  Looks like it thinks libdts == libdca.

Checking for libdca support ... yes
Comment 9 Steve Dibb (RETIRED) gentoo-dev 2007-08-15 06:41:11 UTC
Okay, so the configure flag is dca, not dts.  No wonder I missed it.  Reopening.
Comment 10 Steve Dibb (RETIRED) gentoo-dev 2007-08-15 06:49:14 UTC
Fixed in 1.0.20070814, added optional dep for libdca, also now disables DTS support completely w/o use flag.

Thanks