Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 186393 - mail-mta/nullmailer-1.03 version bump
Summary: mail-mta/nullmailer-1.03 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Robin Johnson
URL: http://untroubled.org/nullmailer/
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-23 22:54 UTC by Stefan Briesenick (RETIRED)
Modified: 2008-02-28 21:33 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild for nullmailer from debian/stable (nullmailer-1.03.ebuild,4.55 KB, text/plain)
2007-11-16 19:45 UTC, Leonid Evdokimov
Details
ebuild for nullmailer-1.04 from debian/testing (nullmailer-1.04.ebuild,4.44 KB, text/plain)
2008-02-01 14:41 UTC, Leonid Evdokimov
Details
nullmailer-1.02-r2-1.03-r1.ebuild (nullmailer-1.03-r1-test.diff,3.21 KB, patch)
2008-02-20 00:04 UTC, Robin Johnson
Details | Diff
adding nodjb USE flag to Thilo's ebuild. (nullmailer-1.04-nodjb.patch,2.30 KB, patch)
2008-02-24 13:22 UTC, Leonid Evdokimov
Details | Diff
1.04 vs 1.02-r2 (nullmailer-patch.diff,5.85 KB, patch)
2008-02-26 21:31 UTC, Thilo Bangert (RETIRED) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Stefan Briesenick (RETIRED) gentoo-dev 2007-07-23 22:54:50 UTC
see summary. new version available. thanks!


Reproducible: Always

Steps to Reproduce:
Comment 1 Leonid Evdokimov 2007-11-16 16:25:50 UTC
1.04 is available
Comment 2 Leonid Evdokimov 2007-11-16 19:45:28 UTC
Created attachment 136103 [details]
ebuild for nullmailer from debian/stable

I also added two use-flags:

*ipv6* to enable/disable ipv6 patch. Seems, it's right assumption that ipv6 patch adds ipv6 support (is not ipv6-related bugfix patch).

*djb* to disable daemontools scripts usage as init.d script may be enough.
Comment 3 Leonid Evdokimov 2008-02-01 14:41:10 UTC
Created attachment 142401 [details]
ebuild for nullmailer-1.04 from debian/testing

I replaced use-flag "djb" with "nodjb" for backwards-compatibility with existing ebuild.

1.04 fixed one annoying bug:
- Fixed rewriting mail to @localhost if defaultdomain is set by not
  appending .defaultdomain to *@localhost.
(from http://untroubled.org/nullmailer/NEWS)
so now «nullmailer-inject localuser@localhost» works better
Comment 4 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-19 23:31:22 UTC
robin: any objections, if i put some effort into getting this in the tree?
qmqp is broken in older versions....
Comment 5 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-02-20 00:04:59 UTC
Created attachment 144034 [details, diff]
nullmailer-1.02-r2-1.03-r1.ebuild

I haven't tested 1.04 at all, but upstream 1.03 was very crappy and broken.
Find attached the diff between 1.02-r2 and my 1.03-r1 testing build.
Comment 6 Leonid Evdokimov 2008-02-20 09:03:40 UTC
IMHO, 1.03 is worse than 1.04 as it has bug that can't be fixed with configuration tuning.
My test environment is not big, but 1.04 works at least at two my x86 machines resending mail to faraway postfix.
Comment 7 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-24 12:52:43 UTC
i have added my proposal for nullmailer-1.04 to my overlay at
http://overlays.gentoo.org/dev/bangert/browser/ebuilds/mail-mta/nullmailer

i'll look into testing some of these on monday.
Comment 8 Leonid Evdokimov 2008-02-24 13:22:41 UTC
Created attachment 144497 [details, diff]
adding nodjb USE flag to Thilo's ebuild.

By the way. Thilo's ebuild also produces following QA notice
 * QA: stop using the bindnow-flags function ... simply drop it from your ebuild

It's not fixed in this patch.
Comment 9 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-24 13:48:32 UTC
leonid: i had forgotten to commit the removal of the append-ldflags line... fixed now.

also, the nodjb flag is very unlikely to reach the tree... its a negative USE flag, which should not be used. you could use a -djb use flag, but IMHO the changes you attach to it, dont warrant a USE flag. there are other mechanisms to disallow the installation of specific files.
Comment 10 Leonid Evdokimov 2008-02-24 14:52:09 UTC
The only reason that made me select negative flag is keeping backward compatibility with existing installations. If it's not necessary, then I agree that positive flag is much better.

I really don't see another way to achieve the same with settings. I want to make some dependency optional, isn't USE flag right tool for that ?

If I mask daemontools then I'll be unable to install nullmailer.
If I put daemontools to "provided" then I'll lie to portage. Once another package will strictly require daemontools and it'll assume that it's installed, so I'll get broken system.
Comment 11 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-24 15:27:11 UTC
hmm, yeah - you are right. i forgot about that (who doesnt want daemontools on their system ;-). 

then i'd still prefer another name - like daemontools.
robbat2, whats your opinion?
Comment 12 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-02-24 21:49:23 UTC
I'd like to take a middle ground like dev-util/git.

Make this change the postinst output, and take daemontools+supervise-scripts out of the [R]DEPEND. DO still create everything in /var/nullmailer/service/.
FYI, runit can also use the /var/nullmailer/service/ stuff, so it isn't really daemontool-specific that way.

-elog "To start nullmailer at boot you have to enable the /etc/init.d/svscan rc file"
-elog "and create the following link :"
-elog "ln -fs /var/nullmailer/service /service/nullmailer"
-elog "As an alternative, we also provide an init.d script."
+elog "To start nullmailer at boot you may use either the nullmailer init.d"
+elog "script, or emerge sys-process/supervise-scripts, enable the"
+elog "svscan init.d script and create the following link:"
+elog "ln -fs /var/nullmailer/service /service/nullmailer"
Comment 13 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-26 20:22:44 UTC
1.04 works like a charm for me (no auth or login though)

robbat2: great compromise.
then there is the mailwrapper issue. any specific reason why nullmailer deps on the masked version of mailwrapper?
Comment 14 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-02-26 20:41:20 UTC
mailwrapper stuff should be removed, see the stuff from ferdy before - it was a failed experiment in Gentoo.
Comment 15 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-26 21:31:28 UTC
Created attachment 144702 [details, diff]
1.04 vs 1.02-r2

great. i have updated the ebuild in my overlay - find attached a diff to 1.02-r2.

feel free to cherry pick :)
comments, critics and flames welcome.
Comment 16 Robin Johnson archtester Gentoo Infrastructure gentoo-dev Security 2008-02-27 02:44:13 UTC
comments on the latest patch:
- please install the ChangeLog
- ipv6 non-optional. The patch should always be applied, the configure test will handle the system correctly.
- should have a !virtual/mta in RDEPEND

Other than that, if it works for you, +1 for you to commit it, and feel free to list yourself in the metadata too.
Comment 17 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-28 08:05:18 UTC
nullmailer-1.04 is in the tree now.

there was another problem with the sample config - the syntax for smtp auth had changed. we now install a version of the file which is accurate again. i was also able to test smtp auth and it works fine for me - both PLAIN and LOGIN.

i haven't removed the mask on 1.04 yet - but will do so tonight (that's in roughly 12 hours) - unless somebody beats me to it.

also i thought we might remove the older unstable ebuilds and get 1.04 marked stable soonish (as in 30 days) - if nothing shows up.
Comment 18 Thilo Bangert (RETIRED) (RETIRED) gentoo-dev 2008-02-28 21:33:35 UTC
mask on nullmailer-1.04 lifted.
thanks everybody