Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 184812 - set src_test to run by default
Summary: set src_test to run by default
Status: CONFIRMED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All All
: High enhancement (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-07-10 09:19 UTC by SpanKY
Modified: 2019-03-04 11:41 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description SpanKY gentoo-dev 2007-07-10 09:19:48 UTC
looks like this was never filed for tracking ...

EAPI-1 should run src_test by default

note: by default != always run
Comment 1 Petteri Räty (RETIRED) gentoo-dev 2007-07-10 16:36:22 UTC
From the gentoo-dev thread about this it didn't seem like most people would have been in favor of this.
Comment 2 SpanKY gentoo-dev 2007-07-10 18:44:58 UTC
note my note ... the hate on the gentoo-dev mailing list was for the idea of always forcing test regardless of anything else for EAPI-1
Comment 3 Petteri Räty (RETIRED) gentoo-dev 2007-07-10 20:49:59 UTC
(In reply to comment #2)
> note my note ... the hate on the gentoo-dev mailing list was for the idea of
> always forcing test regardless of anything else for EAPI-1
> 

Well to be on by default it probably needs one of those categorization things discussed on the mailing list for resource hungry, very long tests etc. Maybe we should have an additional variable that in global scope that controls whether the tests are run by default.
Comment 4 SpanKY gentoo-dev 2007-07-10 22:18:34 UTC
classifying the resource needs of tests is a different topic i think ... people can still do FEATURES=-test in their make.conf
Comment 5 Ryan Hill (RETIRED) gentoo-dev 2008-06-11 04:26:24 UTC
considering i have 11 system packages[i] i have to override with FEATURES="-test" in /etc/portage/env[ii] to be able to get through an `emerge -e system` successfully, i'd say we're a ways off from having tests enabled by default.

i would love to have a FEATURES="developer" or somesuch that would enable tests, the QA source code warnings, FEATURES="cvs", collision-protect, splitdebug, etc.


[i] dirtyepic@halo /etc/portage/env $ tree
.
|-- app-text
|   `-- poppler-bindings
|-- cross-mips-unknown-linux-gnu
|   |-- binutils
|   |-- gcc
|   `-- glibc
|-- dev-libs
|   |-- boost
|   `-- elfutils
|-- dev-python
|   `-- dbus-python
|-- dev-util
|   |-- dejagnu
|   `-- valgrind
|-- gnome-extra
|   `-- gucharmap
|-- media-libs
|   `-- gst-plugins-base
|-- sci-libs
|   `-- fftw
|-- sys-apps
|   |-- coreutils
|   `-- hal
|-- sys-devel
|   |-- autoconf
|   |-- automake
|   |-- binutils
|   |-- gcc
|   |-- gdb
|   |-- libtool
|   `-- prelink
|-- sys-libs
|   |-- db
|   `-- glibc
`-- x11-libs
    `-- cairo

(some of these might be fixed and i just haven't checked lately)


[ii] yes, ugly hack ;)
Comment 6 Ciaran McCreesh 2008-06-11 04:31:21 UTC
Not at all. When people bump their packages and move to EAPI 2, they'll either fix the test suites that they previously ignored, or if that's not doable they'll restrict tests for that package.

This means that as the tree moves to using newer EAPIs, we'll go from src_test being a lottery (does a failure mean something's wrong or just a lazy maintainer?) to it being reliable.
Comment 7 Doug Goldstein (RETIRED) gentoo-dev 2009-03-10 19:13:25 UTC
While I'd like to see this happen, there are several packages in the tree that require additional dependencies that cause circular dependencies to resolve. For example, I would VERY VERY much like this to be run for cairo because it would reduce the number of bugs filed for cairo to virtually zero. But... cario tests need GTK+ to be installed and available, however GTK+ depends on cairo.

So what we'd need is an ability to specify dependencies for tests that means the package source isn't cleaned and we come back to it after the dependencies are satisfied.
Comment 8 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2013-08-30 10:40:08 UTC
How is PMS actually affected in this one?
Comment 9 Ciaran McCreesh 2013-08-30 19:28:49 UTC
We add in a phrase requiring the PM to run src_test unless the user explicitly disables it, or unless it's RESTRICTed.
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2014-09-06 21:37:53 UTC
So does anyone still care about this one? I doubt we'll get community agreement on running tests by default but feel free to try. Otherwise, we should close this as WONTFIX.
Comment 11 Ciaran McCreesh 2014-09-06 21:43:05 UTC
This one needs someone to step in and show some leadership. In the long term it's best for the distribution.
Comment 12 Ryan Hill (RETIRED) gentoo-dev 2014-09-06 22:51:04 UTC
As long as people continue to blatantly ignore testsuite failures in their packages this feature is worse than useless for the general user.  We've actually made negative progress here; we have many more failures now than we did six years ago.  (I'm actually surprised when a python package passes these days.)  At this point any potential benefit of enabling tests by default is drowned out by the noise of false positives, the added cost in build times and additional dependencies, and the general broken window syndrome that results when our users see every second or third package throwing errors (even non-fatal ones as in this case).

I'd really like it to be enabled.  Barring some major changes in our QA policies, which would make everyone unhappy, I don't see it happening.
Comment 13 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2016-10-31 09:45:11 UTC
I still don't think this is a PMS matter.

Furthermore, I think this is better handled by encouraging developers to enable tests for the packages they maintain. This ofc brings problems for project-maintained packages which usually have many 'bumpers' and no real caring maintainer.

Yet another problem is how developers handle failing tests. It's still a common practice to silently disable any test that fails. In many cases, tests that are broken are straight disabled without attempting to fix them or report the problem upstream. In some cases, the failing tests are disabled without even checking if they don't indicate major problems (it always failed, so why users should be bothered about some known problem with the package?).
Comment 14 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2017-09-08 19:07:17 UTC
If you can get Portage to default to enabling tests, we can think about putting a note about it to PMS. But still, I don't think PMS is really supposed to say what the default for this should be.