Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 184548 - Please stabilize =app-misc/detox-1.1.1-r2
Summary: Please stabilize =app-misc/detox-1.1.1-r2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Gentoo Shell Tools project
URL: http://sourceforge.net/tracker/index....
Whiteboard:
Keywords:
Depends on:
Blocks: 191559
  Show dependency tree
 
Reported: 2007-07-07 22:39 UTC by Maarten Bressers (RETIRED)
Modified: 2008-02-12 23:48 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
Install files with correct permissions (Makefile.in.patch,3.47 KB, patch)
2007-07-07 22:40 UTC, Maarten Bressers (RETIRED)
Details | Diff
Permissions patch so that /usr/bin/detox has correct perms (1.1.1-install-permissions-fix.patch.patch,536 bytes, patch)
2007-12-20 13:22 UTC, Thomas Anderson (tanderson) (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maarten Bressers (RETIRED) gentoo-dev 2007-07-07 22:39:24 UTC
Since /usr/bin/install is called without a permissions argument (-m), all
files get 755 permissions after 'make install', eg:
$ ls -l /etc/detoxrc
-rwxr-xr-x 1 root root 1901 Jul 1 12:41 /etc/detoxrc
This also applies to the man-pages, *.tbl and *.sample files.

Patch for Makefile.in attached.

Reproducible: Always

Steps to Reproduce:
1. emerge app-misc/detox
2.
3.

Actual Results:  
Files have 744 permissions

Expected Results:  
Files should have 644 permissions
Comment 1 Maarten Bressers (RETIRED) gentoo-dev 2007-07-07 22:40:29 UTC
Created attachment 124190 [details, diff]
Install files with correct permissions
Comment 2 Raúl Porcel (RETIRED) gentoo-dev 2007-12-17 18:10:47 UTC
Fixed in -r2, amd64, mips: please stabilize it.
Comment 3 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-12-20 13:16:29 UTC
While the original problem is fixed, -r2 introduces a new bug. /usr/bin/detox doesn't even have +x! My /usr/bin/detox has these permissions:

-rw-r--r-- 1 root root 50634 Dec 20 08:14 detox

Now that is definitely *not* correct. If I have time I'll make up a patch
Comment 4 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-12-20 13:22:43 UTC
Created attachment 138974 [details, diff]
Permissions patch so that /usr/bin/detox has correct perms
Comment 5 Thomas Anderson (tanderson) (RETIRED) gentoo-dev 2007-12-20 13:23:53 UTC
With this patch, /usr/bin/detox has these perms:

-rwxr-xr-x 1 root root 50634 Dec 20 08:27 detox

I'm not done testing though...
Comment 6 Samuli Suominen (RETIRED) gentoo-dev 2007-12-21 17:26:07 UTC
Fixed and amd64 stable.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2008-02-12 23:48:46 UTC
Closing wrt http://www.gentoo.org/news/20080210-mips-experimental-arch.xml