Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 18423 - run-parts $dir gives error if $dir contains .keep file
Summary: run-parts $dir gives error if $dir contains .keep file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All All
: High normal (vote)
Assignee: Seemant Kulleen (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2003-03-29 08:06 UTC by Jukka Salmi
Modified: 2003-04-03 19:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
patches run-parts to ignore .keep files (run-parts.c.patch,396 bytes, patch)
2003-03-29 08:07 UTC, Jukka Salmi
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jukka Salmi 2003-03-29 08:06:51 UTC
if running run-parts from sys-apps/debianutils for a dir containing a .keep
file, run-parts gives an error msg like 'component $dir/.keep is not an
executable plain file'. sys-apps/anacron for instance runs run-parts for the
directories /etc/cron.{daily,weekly,monthly}, which contain .keep files. this
results in error messages mailed to root.

Reproducible: Always
Steps to Reproduce:
$ run-parts --test /etc/cron.weekly
Actual Results:  
run-parts: component /etc/cron.weekly/.keep is not an executable plain file

Expected Results:  
IMHO no error message for .keep files should be printed.

solution #1: run-parts could be patched to ignore .keep files (i'll submit a patch)
solution #2: .keep files in /etc/cron.{daily,weekly,monthly} could be renamed to
.keep.disabled (run-parts ignores files matching *.disabled by default). for
this to happen, sys-apps/baselayout and sys-apps/cronbase and possibly ebuild.sh
would have to be patched.
Comment 1 Jukka Salmi 2003-03-29 08:07:48 UTC
Created attachment 9985 [details, diff]
patches run-parts to ignore .keep files
Comment 2 Jukka Salmi 2003-03-29 08:10:52 UTC
solution #3: .keep files could be chmod()ed to 0755...
Comment 3 Seemant Kulleen (RETIRED) gentoo-dev 2003-04-01 02:52:09 UTC
they're not executable, so I rather prefer the patch method.
Comment 4 Seemant Kulleen (RETIRED) gentoo-dev 2003-04-03 19:21:54 UTC
fixed in -r1. thanks for that.