Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 184126 - app-pda/gtkpod has unconditional gnome-vfs dependency
Summary: app-pda/gtkpod has unconditional gnome-vfs dependency
Status: VERIFIED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High minor
Assignee: Olivier Crete (RETIRED)
URL:
Whiteboard:
Keywords:
: 187272 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-07-03 18:51 UTC by Joe Kappus
Modified: 2009-07-10 22:09 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild deps patch (gtkpod-0.99.10.ebuild.patch,933 bytes, patch)
2007-08-03 21:01 UTC, Vladimir Pouzanov
Details | Diff
autoconf patch for missing options (gtkpod-autoconf.patch,13.94 KB, patch)
2007-08-26 15:52 UTC, Vladimir Pouzanov
Details | Diff
makes gnome-vfs conditional (gtkpod-0.99.10-gnome-vfs.patch,671 bytes, patch)
2007-09-02 08:47 UTC, Pietro Franchi
Details | Diff
makes gnome-vfs conditional (gtkpod-0.99.10-gnome-vfs.patch,670 bytes, patch)
2007-11-13 14:40 UTC, James Blanding
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Kappus 2007-07-03 18:51:56 UTC
emerging gtkpod now bloats my system with useless junk 

Reproducible: Always

Steps to Reproduce:
1.emerge gtkpod
2.watch useless gnome crap install 

Actual Results:  
My system gets bloated with crap.

Expected Results:  
My system should not have been bloated with crap.

Runs without gnome-vfs, builds without gnome-vfs, why the hell should it have gnome-vfs and friends?  Remove junk you don't need from DEPEND, and if it DOES happen to need it when you run bloat, make it have a USE flag so the non-gnome users don't deal with this.
Comment 1 Olivier Crete (RETIRED) gentoo-dev 2007-07-03 19:50:14 UTC
It has a bunch of other compulsory gnome dependencies like gnomecanvas, glade, etc.. So I decided that there really wasnt much of a point trying to have a use flag for a single not-so-big library.
Comment 2 Joe Kappus 2007-07-05 02:03:01 UTC
so what if it requires libgnomecanvas, at least that doesn't pull in 50 new packages, reopening because solution sucks.  gnome-vfs != glade/libgnomecanvas, which do not require a crapload of packages.
Comment 3 sddnd 2007-07-16 10:50:29 UTC
Yes, Please seperate the gnome relatives out.

I do really hate the fat gnome things if not very necessary.

So, if it's possible, please please make the USE flag for we gnome hater.
Comment 4 Jakub Moc (RETIRED) gentoo-dev 2007-07-31 19:03:32 UTC
*** Bug 187272 has been marked as a duplicate of this bug. ***
Comment 5 Vladimir Pouzanov 2007-07-31 19:13:58 UTC
I'd suggest to add support for curl, flac and vorbis USE flags too. However that's not so critical as dozen gnome libs pulling out with gtkpod.
Comment 6 Vladimir Pouzanov 2007-08-03 21:01:07 UTC
Created attachment 126822 [details, diff]
ebuild deps patch

This patch introduces new USE flags. using -gnome lowered number of deps from 24 to just one! gtkpod still works perfectly.

PS: there seems no way to force gtkpod ignore flac/curl/vorbis, but configure detects their absence at run-time and build works. That means it's impossible to remove flac support by -flac, but it's possible to build gtkpod without flac if it's not present in system and re-merging it with USE=flac pulls flac and builds gtkpod with flac support.
Comment 7 Jakub Moc (RETIRED) gentoo-dev 2007-08-10 17:13:38 UTC
Comment on attachment 126822 [details, diff]
ebuild deps patch

(In reply to comment #6)
> PS: there seems no way to force gtkpod ignore flac/curl/vorbis, but configure
> detects their absence at run-time and build works.

Not possible, not acceptable. Get that fixed upstream, until then, the dependencies stay unconditional.

http://www.gentoo.org/proj/en/qa/automagic.xml
Comment 8 Vladimir Pouzanov 2007-08-26 15:52:02 UTC
Created attachment 129245 [details, diff]
autoconf patch for missing options

Here goes a patch that adds missing --with/--without functionality
Comment 9 Olivier Crete (RETIRED) gentoo-dev 2007-08-26 17:05:57 UTC
please send it upstream
Comment 10 Vladimir Pouzanov 2007-08-26 17:22:08 UTC
Uhm, it's from upstream, we just can use it for now in current ebuild.
Comment 11 Pietro Franchi 2007-09-02 08:47:32 UTC
Created attachment 129826 [details, diff]
makes gnome-vfs conditional

This is just part of Vladimir's patch, and only adds gnome-vfs conditional on gnome. I think this is proper as the --without-gnome-vfs switch is already provided by upstream, and if applied will save a lot of gnome stuff to be pulled in.

Cheers,
Pietro
Comment 12 Todd Zullinger 2007-09-30 18:29:19 UTC
If any of you can confirm that the proposed upstream patch works well, I'll commit it.  I was only holding off while waiting to get some feedback in case the changes caused any problems or needed improvement to solve the problem properly.

The thread on gtkpod-devel where we discussed this is at http://article.gmane.org/gmane.comp.ipod.gtkpod/2835 (msg-id = <20070807040344.GC26040@psilocybe.teonanacatl.org>).
Comment 13 Vladimir Pouzanov 2007-09-30 18:40:02 UTC
The patch seems to be ok, at least I don't have any problems with it.
Comment 14 Todd Zullinger 2007-09-30 19:51:30 UTC
Thanks for confirming Vladimir.  That makes 2 of us that it works for.  I've committed this upstream in svn rev 1709: http://gtkpod.svn.sourceforge.net/viewvc/gtkpod?view=rev&revision=1709

I hope this helps make the gentoo ebuild more flexible.  Don't hesitate to ask on gtkpod-devel if there's anything else we can do upstream to help out. :)
Comment 15 James Blanding 2007-11-09 06:29:27 UTC
Hello,

I was just wondering why the patch from comment #11 that makes gnome-vfs conditional was not included in the 0.99.10 ebuild that is now marked stable?
Comment 16 Joe Kappus 2007-11-09 21:09:47 UTC
Because the patch was made AFTER 0.99.10 was put in portage, and the devs are too lazy to put a -r1 version for it.  Just put it in an overlay for now.  It will be included in next release
Comment 17 James Blanding 2007-11-13 14:40:16 UTC
Created attachment 135891 [details, diff]
makes gnome-vfs conditional

Hmm...the patch in comment #11 kicked back the following for me:

!!! Invalid or corrupt dependency specification:

Conditional without flag: "? ( >=gnome-base/gnome-vfs-2.6 )"


I removed the space from the conditional flag and it seemed to build OK...
Comment 18 Samuli Suominen (RETIRED) gentoo-dev 2009-07-10 16:14:38 UTC
oooooold bug :)

fixed in 0.9.14 and above at least
Comment 19 Joe Kappus 2009-07-10 22:09:56 UTC
closing, forgot all about this lol