Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 183336 - gnome-menus-2.18.2 is not *BSD-friendly
Summary: gnome-menus-2.18.2 is not *BSD-friendly
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Gentoo Linux Gnome Desktop Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-26 22:21 UTC by N. Dan Smith
Modified: 2007-07-08 11:54 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
gnome-menus-2.18.2.ebuild.diff (gnome-menus-2.18.2.ebuild.diff,1.13 KB, patch)
2007-06-26 23:00 UTC, Jakub Moc (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description N. Dan Smith 2007-06-26 22:21:40 UTC
The gnome-menus-2.18.2 ebuild has inotify support enabled by default.  In order to make the ebuild *BSD-friendly, there needs to be an option to disable it (since inotify is a feature of the Linux kernel).

There is no "inotify" global USE flag.  There is a libnotify flag, but I am not sure if that is referring to the same thing.  The problem with an inotify USE flag is that in order make the ebuild function the same way for Linux users (enabled by default), the inotify flag would have to be turned on in the Linux profiles and masked in the *BSD profiles(based on my beginner's knowledge of portage anyway).  There is also the option of a "noinotify" flag which could be enabled by default in *BSD profiles.  That is my $0.02.
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-06-26 22:34:56 UTC
What's wrong w/ something like

G2CONF="$(use_enable !kernel_FreeBSD inotify) $(use_enable debug) $(use_enable python)"

?
Comment 2 Rémi Cardona (RETIRED) gentoo-dev 2007-06-26 22:48:31 UTC
What about :

G2CONF="$(use_enable kernel_linux inotify) $(use_enable debug) $(use_enable
python)"

Just to be sure (I haven't look at gnome-menu's code) it's not using the gnome-vfs file monitoring api? That sounds shocking :) Something worth poking upstream about.
Comment 3 Jakub Moc (RETIRED) gentoo-dev 2007-06-26 23:00:15 UTC
Created attachment 123160 [details, diff]
gnome-menus-2.18.2.ebuild.diff

(In reply to comment #2)
> What about :
> 
> G2CONF="$(use_enable kernel_linux inotify) $(use_enable debug) $(use_enable
> python)"
> 
> Just to be sure (I haven't look at gnome-menu's code) it's not using the
> gnome-vfs file monitoring api? That sounds shocking :) Something worth poking
> upstream about.

Haven't checked either; anyway, if we enable inotify, it'd better be enabled in kernel. :P Patch attached.
Comment 4 N. Dan Smith 2007-06-26 23:18:06 UTC
gnome-menus-2.18.0 also needs the same treatment.
Comment 5 Jakub Moc (RETIRED) gentoo-dev 2007-07-08 11:54:14 UTC
  27 Jun 2007; Roy Marples <uberlord@gentoo.org> gnome-menus-2.18.2.ebuild:
  Only enable inotify if using a Linux kernel.