Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182856 - x11-base/x11-drm-20070314 patch to enable building on x86-fbsd
Summary: x11-base/x11-drm-20070314 patch to enable building on x86-fbsd
Status: RESOLVED FIXED
Alias: None
Product: Gentoo/Alt
Classification: Unclassified
Component: FreeBSD (show other bugs)
Hardware: All FreeBSD
: High normal (vote)
Assignee: Bryan Stine (RETIRED)
URL: https://bugs.freedesktop.org/show_bug...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-22 01:18 UTC by Joe Peterson (RETIRED)
Modified: 2008-09-12 05:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
x11-drm-20070314.ebuild (x11-drm-20070314.ebuild.diff,560 bytes, patch)
2007-06-22 01:20 UTC, Joe Peterson (RETIRED)
Details | Diff
files/x11-drm-20070314-freebsd.patch (x11-drm-20070314-freebsd.patch,256 bytes, patch)
2007-06-22 01:20 UTC, Joe Peterson (RETIRED)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joe Peterson (RETIRED) gentoo-dev 2007-06-22 01:18:39 UTC
When I tried to build this package on Gentoo/FreeBSD, I encountered an issue with bsd-core/drmP.h - the drm_ati_pcigart_info struct was missing one element that the linux-core version has:  "int table_size;".

The attached patch and ebuild fix this.
Comment 1 Joe Peterson (RETIRED) gentoo-dev 2007-06-22 01:20:19 UTC
Created attachment 122771 [details, diff]
x11-drm-20070314.ebuild
Comment 2 Joe Peterson (RETIRED) gentoo-dev 2007-06-22 01:20:46 UTC
Created attachment 122773 [details, diff]
files/x11-drm-20070314-freebsd.patch
Comment 3 Donnie Berkholz (RETIRED) gentoo-dev 2007-06-22 05:40:27 UTC
Please send this patch upstream. You can file a bug in the DRI product at bugs.freedesktop.org. Once you do, please post the URL here so we can track it. Thanks!
Comment 4 Joe Peterson (RETIRED) gentoo-dev 2007-06-22 14:40:57 UTC
Bug filed here:

https://bugs.freedesktop.org/show_bug.cgi?id=11336
Comment 5 Joe Peterson (RETIRED) gentoo-dev 2007-06-22 14:46:56 UTC
BTW, question: since this is marked as "resolved", how is it tracked through final resolution?  Is it marked "closed" when the upstream patch is included and the problem is fixed?

Also, should I remove ~x86-fbsd keyword in the meantime?
Comment 6 Donnie Berkholz (RETIRED) gentoo-dev 2007-06-22 15:52:50 UTC
(In reply to comment #5)
> BTW, question: since this is marked as "resolved", how is it tracked through
> final resolution?  Is it marked "closed" when the upstream patch is included
> and the problem is fixed?

Please reopen it when the upstream patch is accepted. Then we will add the patch and mark the bug FIXED.

> Also, should I remove ~x86-fbsd keyword in the meantime?

That's your call.
Comment 7 Joe Peterson (RETIRED) gentoo-dev 2007-06-25 18:12:45 UTC
Apparently, upstream's current sources look good.  See below:

------- Comment #1 from bugzi06.fdo.tormod@xoxy.net  2007-06-25 10:08 PST -------
CVS is not used any longer, but git:
http://gitweb.freedesktop.org/?p=mesa/drm.git;a=summary

And there the structure looks good. This was fixed in commit
b0c8d885ce645aee5027a75e4149ba4be265b55d
Comment 8 Donnie Berkholz (RETIRED) gentoo-dev 2007-06-25 18:15:57 UTC
(In reply to comment #7)
> Apparently, upstream's current sources look good.  See below:
> 
> ------- Comment #1 from bugzi06.fdo.tormod@xoxy.net  2007-06-25 10:08 PST
> -------
> CVS is not used any longer, but git:
> http://gitweb.freedesktop.org/?p=mesa/drm.git;a=summary
> 
> And there the structure looks good. This was fixed in commit
> b0c8d885ce645aee5027a75e4149ba4be265b55d

Thanks for looking into this! We should probably just bump x11-drm. Bryan?
Comment 9 Bryan Stine (RETIRED) gentoo-dev 2007-06-27 21:21:54 UTC
I'm working on a bump. The hang-up is due to changes on some things on the Linux side.
Comment 10 Bryan Stine (RETIRED) gentoo-dev 2008-09-12 05:20:08 UTC
Pushed patchball 0.4 for 20070314, with that FreeBSD fix. Hopefully it works, I've no way of testing. This version is being kept around for DRI compatibility (i810 that I know of so far).

20080710 should have the upstream fix included.