Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182783 - mythtv-plugins svn ebuilds should use the same source directory
Summary: mythtv-plugins svn ebuilds should use the same source directory
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Eclasses (show other bugs)
Hardware: All Linux
: High enhancement (vote)
Assignee: Doug Goldstein (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-21 12:51 UTC by Tom Clift
Modified: 2007-06-28 18:41 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Clift 2007-06-21 12:51:26 UTC
The svn ebuilds inheriting mythtv-plugins checkout the 'mythplugins' directory from the repo into /usr/portage/distfiles/svn-src/<plugin_name>/mythplugins .  This is redundant - mythtv users on svn might (and probably will) have several plugins installed at once.  It puts extra strain on their svn server and takes up more room on my HDD.

It would be good if all the mythtv-plugins shared the same svn checkout of mythplugins.

One possible way to do this is to add the following line to the top of mythtv-plugins.eclass :

ESVN_PROJECT=""

From what I understand from reading subversion.eclass, the source will be checked out to: ${ESVN_STORE_DIR}/${ESVN_PROJECT}/${ESVN_REPO_URI##*/}

Given that ${ESVN_REPO_URI} for a plugin is something like "mythplugins/mythvideo", if we set ${ESVN_PROJECT} to a blank string, we would get a directory like:

/usr/portage/distfiles/svn-src//mythplugins/mythvideo/

While perhaps this is a bit of a bastardisation (the whole double slash thing), it does ensure that all mythtv-plugins get checked out to the same directory.

This is my first bug report so please let me know if I've stuffed something up.

Reproducible: Always

Steps to Reproduce:
Install a 'pre' (svn) version of a mythtv plugin.
Actual Results:  
Source gets checked out to a separate directory.

Expected Results:  
Source gets checked out to a directory common to all mythtv-plugins.

Possible solution - add to the top of mythtv-plugins.eclass :

ESVN_PROJECT=""
Comment 1 Tom Clift 2007-06-21 13:10:30 UTC
Also, mythmovies needs to be added to the list of mythplugins so that it's not built (guess this is a known issue because it's pretty recent, but thought I should mention it anyway.

if version_is_at_least "0.21_pre" ; then
    MYTHPLUGINS="${MYTHPLUGINS} mythmovies mythzoneminder"
fi

(and mythdvd can be removed, but that's in a separate bug here: http://bugs.gentoo.org/show_bug.cgi?id=180696 )
Comment 2 Jakub Moc (RETIRED) gentoo-dev 2007-06-21 15:20:29 UTC
Something doesn't work for you? If so, let us know. Otherwise, the point of this bug is exactly what?
Comment 3 Tom Clift 2007-06-21 23:29:56 UTC
(In reply to comment #2)
> Something doesn't work for you? If so, let us know. Otherwise, the point of
> this bug is exactly what?

The point of this bug is to improve the behaviour of the eclass.  Hence why I filed it as 'enhancement'.  Is there something the matter with submitting enhancements?
Comment 4 Doug Goldstein (RETIRED) gentoo-dev 2007-06-28 18:34:04 UTC
Why'd this get closed?
Comment 5 Doug Goldstein (RETIRED) gentoo-dev 2007-06-28 18:35:21 UTC
I like the suggestion.
Comment 6 Doug Goldstein (RETIRED) gentoo-dev 2007-06-28 18:41:09 UTC
Fixed. Nice suggestion Tom. Sorry for not getting back to you via e-mail. I've been moving and without my mail server for about a week.