Bug 182652 – [fPIC] patch for dev-libs/libpcre-7.1 to compile libraries with PIC

• Status: RESOLVED INVALID
• Product: Gentoo Linux

[Description Simon Cooper 2007-06-20 10:06:08 UTC]

app-shells/zsh-4.3.4 requires libpcre libraries to be built with PIC on AMD64, this patch enables this. Its probably worth checking if this is an AMD64-specific thing or is required on other arches as well

[Comment 1 Simon Cooper 2007-06-20 10:07:50 UTC]

Created attachment 122582 [details, diff]
patch to build libraries with dPIC

[Comment 2 Jakub Moc (RETIRED) 2007-06-20 11:10:02 UTC]

*** Bug 182534 has been marked as a duplicate of this bug. ***

[Comment 3 Petteri Räty (RETIRED) 2007-06-20 13:26:54 UTC]

(In reply to comment #1)
> Created an attachment (id=122582) [edit]
> patch to build libraries with dPIC
> 

Please submit your patch upstream and attach the url here.

[Comment 4 Simon Cooper 2007-06-21 09:18:12 UTC]

I have contacted upstream, and he recommends applying the patch in the ebuild, as adding -fPIC in the Makefile is not portable and not needed on most platforms. Also, PCRE-7.2 has just been released, so any patches won't get into official releases for some time. The patch in the ebuild applies successfully to libpcre-7.1 and 7.2

[Comment 5 Christoph Mende (RETIRED) 2007-07-15 11:26:24 UTC]

Carlo, any news on this? Upstream's statement is plain wrong, -fPIC may not be needed on all archs, but libpcre-7 is in it's current state broken and unusable on amd64

[Comment 6 Christoph Mende (RETIRED) 2007-07-16 17:48:11 UTC]

Forgot to close here, patch is commited.

[Comment 7 SpanKY 2007-09-18 13:40:13 UTC]

err, wait ... i think there's some confusion floating around here leading to broken ebuilds

first off, you cant just go patching Makefile.am files without running autotools (which is exactly what's happening now)

second, upstream is correct in saying -fPIC is not portable because it isnt ... that's the entire point of using libtool in the first place -- it handles the details of how to build PIC shared objects

third, libtool should be doing the right thing *internally* when it encounters libfoo_la_... defines in Makefile's -- it generates libfoo.a w/out PIC and then it generates libfoo.so w/PIC

finally, where's the actual errors ?  zsh build fails for me *because zsh is broken*, not because of libpcre ... it forces libpcre to be linked statically into a shared object

[Comment 8 Christoph Mende (RETIRED) 2007-09-27 18:47:49 UTC]

(In reply to comment #7)
> second, upstream is correct in saying -fPIC is not portable because it isnt ...
I was talking about the need of -fPIC, but well, seems like that was wrong anyways

> finally, where's the actual errors ?  zsh build fails for me *because zsh is
> broken*, not because of libpcre ... it forces libpcre to be linked statically
> into a shared object
the error is in zsh's own bug (bug 182534), since - like you said - this is a bug in zsh's ebuild I'll close this bug here, zsh already has its own