Bug 182639 – Packages inheriting elisp-common and using a wrong condition for calling elisp-site-regen

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Ulrich Müller 2007-06-20 05:58:37 UTC]

The following packages inherit elisp-common.eclass but do not use the right condition for calling elisp-site-regen:

   app-i18n/anthy/anthy
   app-i18n/anthy-ss
   app-i18n/uim-svn
   kde-base/kdvi
   app-office/magicpoint
   dev-util/bzr
   dev-util/mercurial

The typical pattern (with some variations) is:

   pkg_postinst() {
       use emacs && elisp-site-regen
   }

   pkg_postrm() {
       has_version virtual/emacs && elisp-site-regen
   }

This is WRONG. The condition should be "use emacs" both in pkg_postinst() and pkg_postrm(). Please fix it in your packages.

[Comment 1 Wulf Krueger (RETIRED) 2007-06-20 16:15:26 UTC]

kde-base/kdvi is fixed. KDE is out of here. :-)

[Comment 2 Marien Zwart (RETIRED) 2007-06-22 00:02:51 UTC]

Fixed dev-util/bzr, thanks for complaining :)

[Comment 3 MATSUU Takuto (RETIRED) 2007-06-24 03:33:11 UTC]

i think its wrong solution.

For example,
# USE=emacs emerge anthy
# USE=-emacs emerge anthy

50anthy-gentoo.el was removed and elisp-site-regen didn't run.

[Comment 4 Ulrich Müller 2007-06-24 06:33:45 UTC]

(In reply to comment #3)
> i think its wrong solution.

But obviously, you didn't bother testing it. ;-)

> For example,
> # USE=emacs emerge anthy
> # USE=-emacs emerge anthy

The status of USE=emacs when unmerging is taken from the database, so unsetting it between merge and unmerge has no effect.

[Comment 5 MATSUU Takuto (RETIRED) 2007-06-24 15:56:24 UTC]

I'm sorry. that's right. I didn't test it.

app-i18n/anthy
app-i18n/anthy-ss
app-i18n/uim-svn
fixed.

[Comment 6 Andrew Ross (RETIRED) 2007-06-30 07:25:53 UTC]

Thanks for pointing this out. dev-util/mercurial fixed with no rev bump.

[Comment 7 Ulrich Müller 2007-06-30 08:33:58 UTC]

Fixed app-office/magicpoint myself, since usata is away.