Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 182423 - app-emacs/remember depends on planner but it shouldn't
Summary: app-emacs/remember depends on planner but it shouldn't
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: New packages (show other bugs)
Hardware: All Linux
: High normal
Assignee: Emacs project
URL: http://www.emacswiki.org/cgi-bin/wiki...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-06-18 06:04 UTC by Maxim Loginov
Modified: 2007-06-25 18:49 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
app-emacs/remember-1.9-r1.ebuild (remember-1.9-r1.ebuild,789 bytes, text/plain)
2007-06-22 09:05 UTC, Maxim Loginov
Details
build log (app-emacs:remember-1.9-r1:20070622-082727.log,3.21 KB, text/plain)
2007-06-23 05:01 UTC, Maxim Loginov
Details
emerge --info (emerge--info,7.47 KB, text/plain)
2007-06-23 05:02 UTC, Maxim Loginov
Details
remember-1.9-compile-status.patch (patch,320 bytes, patch)
2007-06-25 05:36 UTC, Ulrich Müller
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Loginov 2007-06-18 06:04:50 UTC
ebuild has 

RDEPEND="app-emacs/bbdb
        app-emacs/planner"
DEPEND="${RDEPEND}"

but remember can work without planner! I'm not sure if it can work standalone
but certainly it can work with org-mode supplied with emacs-22.1
could you please fix the ebuild?


Reproducible: Always

Actual Results:  
require to install app-emacs/planner


Expected Results:  
not to install app-emacs/planner
Comment 1 Jakub Moc (RETIRED) gentoo-dev 2007-06-18 06:34:26 UTC
Not really; see Bug 172137 Comment #3
Comment 2 Maxim Loginov 2007-06-22 09:01:20 UTC
I made an ebuild and it works for me without app-emacs/planner or app-emacs/org-mode, it works for me with emacs-22.1. please test
Comment 3 Maxim Loginov 2007-06-22 09:05:56 UTC
Created attachment 122785 [details]
app-emacs/remember-1.9-r1.ebuild
Comment 4 Ulrich Müller gentoo-dev 2007-06-22 12:54:30 UTC
(In reply to comment #2)
> I made an ebuild and it works for me without app-emacs/planner or
> app-emacs/org-mode, it works for me with emacs-22.1. please test

This fails for me (Emacs 22, app-emacs/planner not installed) with the same error messages as in bug #172137 comment #3. Which is not really surprising, since some source files, e.g., remember-planner.el, contain an unconditional "(require 'planner)". Or am I missing something?

Could you please attach your build log for the ebuild of attachment #122785 [details]?
Comment 5 Maxim Loginov 2007-06-23 05:01:14 UTC
Created attachment 122852 [details]
build log

here is the log requested
you are right, the build produce errors, but installation did not failed (I'm surprised also). I tested remember not extensively, but it seems to work with build-in org-mode and with app-emacs/org-mode in emacs-22.1
please see next attachment for details of my gentoo installation (emerge --info)
Comment 6 Maxim Loginov 2007-06-23 05:02:23 UTC
Created attachment 122853 [details]
emerge --info
Comment 7 Ulrich Müller gentoo-dev 2007-06-23 06:19:08 UTC
(In reply to comment #5)
> you are right, the build produce errors, but installation did not failed
> (I'm surprised also).

remember's Makefile is broken and ignores the return status of the compilation (the "|| :" is a crime):

%.elc: %.el
	@$(EMACS) -q $(SITEFLAG) -batch -l ./scripts/$(PROJECT)-build.el \
		-f batch-byte-compile $< || :

For the failing files, there are no *.elc files written; you see it also in your log. So we won't remove planner from remember's dependencies. On the contrary, it looks like some dependencies are still missing, e.g., emacs-wiki.

If remember really works with org-mode and without planner then my advice is that you should ask Upstream to resolve this issue. (And tell them that they should fix their broken Makefile!)
Comment 8 Maxim Loginov 2007-06-25 04:43:54 UTC
hm... these dependencies (including planner) are optional, see http://bugs.gentoo.org/show_bug.cgi?id=80418
Comment 9 Ulrich Müller gentoo-dev 2007-06-25 05:35:33 UTC
(In reply to comment #8)
> hm... these dependencies (including planner) are optional,

O.K., looks like you really want this feature. ;-)

One possible solution would be to add local USE flags for all optional dependencies to remember. For example:

RDEPEND="bbdb? ( app-emacs/bbdb )
    planner? ( app-emacs/planner )"

And remove all failing files:

src_unpack() {
    unpack ${A}
    cd "${S}"
    epatch "${FILESDIR}/${P}-compile-status.patch"

    use bbdb || rm -f foo.el bar.el
    use planner || rm -f quux.el
}

Maxim: It would be of great help if you could provide us with a list of which dependencies are needed by which files.

Reopening.
Comment 10 Ulrich Müller gentoo-dev 2007-06-25 05:36:33 UTC
Created attachment 123015 [details, diff]
remember-1.9-compile-status.patch
Comment 11 Ulrich Müller gentoo-dev 2007-06-25 18:49:03 UTC
Fixed in -r1: Added bbdb and planner local USE flags, as outlined in comment #9.

For the time being, files remember-{bibl,blosxom,emacs-wiki-journal}.el cannot be compiles since they require "emacs-wiki-journal", "emacs-wiki-blosxom", and "bibl-mode" that are not available in Gentoo.